`lib/use-auth.js` is now the sole client-side auth surface (P1 §9 of
`.convoys/ship-readiness.md`). The legacy `lib/auth-context.js`
(`AuthProvider` + `useAuth`) and `lib/admin-auth.js` (`AdminProvider` +
`useAdmin` + `useIsAdmin`) are deleted; every importer is migrated to
the canonical hook. Pre-convoy a worst-case page mount issued THREE
identical `GET /api/auth/verify` requests (one per provider/hook); the
post-convoy floor is one verify per page mount (3 → 1 on
`pages/card/[id].js`, 2 → 1 elsewhere).
Importer inventory swept (7 source files):
- `pages/_app.js` — removed `<AuthProvider>` wrapper; `<ThemeProvider>`
is now the only top-level provider. `lib/use-auth.js` is hook-only,
no replacement provider needed.
- `pages/index.js`, `pages/scanner.js`, `pages/decks.js`,
`pages/deck/[id].js`, `pages/deck-builder.js` — `import { useAuth }`
path swap from `../lib/auth-context` to `../lib/use-auth`. All five
pages destructured only `{ user }` or `{ user, loading }`; verified
no consumer reads `login` / `register` from useAuth (those flows are
in `pages/login.js` / `pages/signup.js` which call the API directly),
so no shape-parity gap on `lib/use-auth.js`.
- `pages/card/[id].js` — replaced `useIsAdmin()` (the only consumer of
`lib/admin-auth.js` anywhere in the tree) with synchronous
`user?.role === 'admin'` derived from the existing `useAuth()` call.
Render condition at line 524 stays byte-identical.
Decisions documented in `.convoys/single-auth-provider.md`:
- D1: no extension to `lib/use-auth.js` (zero call sites for `login` /
`register` from useAuth — those flows are direct fetches in
`login.js` / `signup.js`).
- D2: `useIsAdmin()` collapses onto `useAuth()`; no separate hook.
- D3: provider tree `<ThemeProvider><AuthProvider>{children}</AuthProvider></ThemeProvider>`
→ `<ThemeProvider>{children}</ThemeProvider>`.
- D4: 3 → 1 verify roundtrip on `card/[id].js`; 2 → 1 on every other
page-load.
- D5: zero test files modified; the 21-test vitest suite is server-
side or prop-driven (`Layout.test.js` passes `user` as a prop, never
imports the legacy hooks).
Doc / config updates so the deletion lands cleanly:
- `.github/CODEOWNERS` — drop the two CODEOWNERS lines for the deleted
files.
- `AGENTS.md` § 2 architecture row + § 3 "Auth (client)" bullet —
rewritten for the post-convoy single-surface state.
- `.cursor/rules/auth-and-permissions.mdc` — § "Legacy" reframed to
"deleted by this convoy"; § "Authentication state on the client"
updated to the post-convoy `useAuth()` shape and the direct-fetch
login flow used by `login.js` / `signup.js`.
- `.cursor/rules/no-go-zones.mdc` — auth-refactors bullet drops the
deleted files from the canonical list.
- `.cursor/skills/add-page/SKILL.md` — checklist + anti-pattern row
refer to the deletion.
Verification:
- `rg "lib/auth-context|lib/admin-auth" --type js` → 0 hits in source.
- `npm run lint` → 128 → 125 problems (3 fewer errors from the deleted
unused-import lines; no regression).
- `npm run test:run` → 21/21 pass (including the 5 Layout regression
locks from `fix-layout-default-user`, which are prop-driven and
unaffected).
- `npm run build` → all 26 pages compile end-to-end; no SSR / static-
generation breakage that would have surfaced if a page tried to use
the legacy context hook unwrapped.
- Manual smoke deferred to operator post-merge per convoy doc.
Risks (full discussion in convoy file):
- R1 shape parity gap — verified zero consumers of legacy-only
surface; mitigated.
- R2 SSR mismatch from removing `<AuthProvider>` — `useEffect`-
guarded `localStorage` read; identical SSR shape pre/post; build
passes.
- R3 missed importer — post-delete grep + build pass would surface
any miss.
- R5 stale `useAuth` cache across components — pre-existing
pattern, called out as follow-up rather than addressed here.
Out of scope: any change to `lib/permission-middleware.js` (server-
side; resolved P0 #1), `lib/auth-secret.js` (resolved P0 #2),
`pages/api/**` route handlers, login / register API contracts, or
the seeded admin account flow.
Co-authored-by: Cursor <cursoragent@cursor.com>
3.8 KiB
3.8 KiB
| name | description |
|---|---|
| add-page | Add a new Next.js page under pages/. Use when you need a new route, a new view for an existing resource, or an admin-only screen. Covers Layout wiring, auth, theme tokens, and the public/authenticated split pattern. |
Add a page
pages/<file>.js becomes a route. Pages router conventions:
| File | Route |
|---|---|
pages/about.js |
/about |
pages/cards/[id].js |
/cards/:id (but use pages/card/[id].js per existing naming) |
pages/admin/index.js |
/admin |
Step 1: Decide auth shape
| Mode | Template |
|---|---|
| Public-only | Render without ProtectedRoute; no auth check |
| Auth-required | Wrap top-level export with <ProtectedRoute> |
| Admin-only | Wrap with <AdminProtected> from components/AdminProtected.js |
Public + auth-enhanced (e.g. /cards) |
Inline split: render <PublicView> if not logged in, <AuthedView> if logged in. Copy the pattern from pages/cards.js. |
Step 2: Skeleton
import { useState, useEffect } from 'react';
import Layout from '../components/Layout';
import ProtectedRoute from '../components/ProtectedRoute';
import { useAuth } from '../lib/use-auth';
export default function MyPage() {
return (
<ProtectedRoute>
<MyPageInner />
</ProtectedRoute>
);
}
function MyPageInner() {
const { user, loading } = useAuth();
const [items, setItems] = useState([]);
const [fetching, setFetching] = useState(false);
useEffect(() => {
if (loading || !user) return;
const token = localStorage.getItem('auth_token');
setFetching(true);
fetch('/api/my-resource', {
headers: { Authorization: `Bearer ${token}` },
})
.then((r) => r.json())
.then((data) => setItems(data.items || []))
.catch((err) => console.error('fetch failed', err))
.finally(() => setFetching(false));
}, [user, loading]);
return (
<Layout user={user} showSearch={false}>
<div className="p-6" style={{ backgroundColor: 'var(--bg-primary)' }}>
<h1 className="text-2xl font-bold" style={{ color: 'var(--text-primary)' }}>
My Page
</h1>
{fetching ? <p>Loading…</p> : items.map((i) => <div key={i.id}>{i.name}</div>)}
</div>
</Layout>
);
}
Step 3: Theme tokens (not hex)
- Backgrounds →
var(--bg-primary),var(--bg-secondary),var(--bg-tertiary) - Text →
var(--text-primary),var(--text-secondary) - Accents →
var(--accent-ember),var(--accent-flame) - Borders →
var(--border)
Use Tailwind for layout, spacing, sizing, hover/focus states. Use CSS vars (inline style={{ ... }}) for colors that need to switch with theme.
Step 4: Always pass user to Layout
<Layout user={user}> — never let the default kick in (it's a hardcoded maintainer email; see AGENTS.md Gotcha #8).
Step 5: Mobile
components/Layout.js already handles the mobile drawer + bottom nav. To add the page to nav, edit NavigationContent in Layout.js. Use existing icon names from the getIcon registry; add new ones to that registry before referencing.
Step 6: Check
- Auth wrapper chosen (ProtectedRoute / AdminProtected / public).
useAuth()fromlib/use-auth.js(the only client auth hook;lib/auth-context.jsandlib/admin-auth.jswere deleted by thesingle-auth-providerconvoy).userpassed to Layout explicitly.- Colors come from theme tokens, not hex.
- All interactive elements have
aria-labelor visible text. - Mobile: confirm the page renders in the mobile drawer.
Anti-patterns
| Don't | Do |
|---|---|
| Hardcode hex colors | Use CSS variables |
Default user = { … } to a real email |
Default to null |
Reintroduce lib/auth-context or lib/admin-auth (deleted) |
Use lib/use-auth |
| Render Layout twice on the same page | Single <Layout> at the top |