fix(api): validate quantity on POST /api/user-cards (#46 )

Match decks handler parseInt/NaN guard so non-numeric quantities cannot
corrupt user_cards row counts from scanner add paths.

Co-authored-by: Cursor <cursoragent@cursor.com>

2026-05-27 14:25:20 -05:00

1.6 KiB

Raw Blame History

convoy

multitask_group

prs

audited_at

outcome

redesign-scanner-flow

audit-redesign-scanner-flow-44

2026-05-27

comment-only

Post-PR audit: redesign-scanner-flow

Combined diff: 55af7e3..673af83 (Briefs 1–3, PRs #42–#44).

Rollup

Role	Recommendation	Blockers
Reviewer	comment-only	0 critical
Design system	7 token violations (pre-existing `CameraScanner.js` overlay)	0 blockers
A11y	8 critical, 8 warnings	Ownership badge + modal focus

Reports posted to PR #44.

Follow-up convoys (queued)

Slug	Priority	Source
`scanner-redesign-a11y-fixes`	P1	RESOLVED — PR #45
`scanner-user-cards-quantity-guard`	P2	In progress — PR pending
`test-scanner-redesign-surfaces`	P2	Reviewer — unit tests for new components + upload route
`document-condition-foil-destination-semantics`	P3	Reviewer — clarify or migrate condition/foil for collection/deck rows
`camera-scanner-token-cleanup`	P3	Design system — replace hardcoded hex overlay colors in CameraScanner

Acceptance criteria sign-off

#	Criterion	Status
1	Single destination; scans auto-route	✅
2	Condition/foil/quantity propagate	⚠️ owned only; collection/deck accept but don't persist
3	Ownership badge	⚠️ works visually; a11y role missing
4	Scan image URL on user_cards	✅
5	Lint + vitest baseline	✅
6	Destination picker keyboard + badge a11y	⚠️ picker ✅; badge ❌

1.6 KiB Raw Blame History Unescape Escape

Post-PR audit: redesign-scanner-flow

Rollup

Follow-up convoys (queued)

Acceptance criteria sign-off

1.6 KiB

Raw Blame History