Normalize collector numbers in catalog match and harden scanner adds #53

Merged

varutasu merged 1 commit from feat/scanner-collector-number-match into main

2026-05-28 15:45:55 -04:00

varutasu commented

2026-05-28 15:22:13 -04:00

(Migrated from github.com)

Summary

Add shared lib/card-number-utils.js so catalog sync reconciliation and scan identification treat 015/208 and 15/208 as equivalent.
Update matchCardInCatalog to retry name+set candidates with normalized collector numbers before queueing a submission.
Finish scanner reliability polish: in-flight locks on owned/collection/deck/auto-route actions, plus disabled "Adding…" state on Mark Owned.

Most items from the scanner-correctness-polish convoy were already shipped in the scanner redesign; this closes the remaining gaps.

Test plan

npm run test:run — 49/49 green
After deploy: scan a card whose OCR reports a leading-zero collector number and confirm it matches the catalog row
Double-click Mark Owned — only one POST

Made with Cursor

## Summary - Add shared `lib/card-number-utils.js` so catalog sync reconciliation and scan identification treat `015/208` and `15/208` as equivalent. - Update `matchCardInCatalog` to retry name+set candidates with normalized collector numbers before queueing a submission. - Finish scanner reliability polish: in-flight locks on owned/collection/deck/auto-route actions, plus disabled "Adding…" state on Mark Owned. Most items from the `scanner-correctness-polish` convoy were already shipped in the scanner redesign; this closes the remaining gaps. ## Test plan - [x] `npm run test:run` — 49/49 green - [ ] After deploy: scan a card whose OCR reports a leading-zero collector number and confirm it matches the catalog row - [ ] Double-click Mark Owned — only one POST Made with [Cursor](https://cursor.com)

vercel[bot] commented

2026-05-28 15:22:19 -04:00

(Migrated from github.com)

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tcg-vault	Ready	Preview, Comment	May 28, 2026 7:22pm

[vc]: #XfhxoGWVwglIx0ZkRr4o0MV951H2pZoa1S7bVUYpDwI=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMvdGNnLXZhdWx0LzN5ZFJlN21qNzN6ejJ1eTdCWUUzVjU3b1dOb1UiLCJwcmV2aWV3VXJsIjoidGNnLXZhdWx0LWdpdC1mZWF0LXNjYW5uZXItYy1iZjdiZmUtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoidGNnLXZhdWx0LWdpdC1mZWF0LXNjYW5uZXItYy1iZjdiZmUtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAifSwicm9vdERpcmVjdG9yeSI6bnVsbH1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj01MyJ9 The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/3ydRe7mj73zz2uy7BYE3V57oWNoU) | [Preview](https://tcg-vault-git-feat-scanner-c-bf7bfe-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-feat-scanner-c-bf7bfe-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | May 28, 2026 7:22pm | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=53" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>

github-actions[bot] commented

2026-05-28 15:22:28 -04:00

(Migrated from github.com)

Pipeline Health

Build + CI gates

Gate	Status
Vercel build (Preview)	✅ pass
CI: Lint	✅ pass
CI: Schema map fresh	❌ skipped
Preview smoke	✅ pass
Visual diff	✅ pass

Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build).

Role reports

Role	Status
Reviewer report	⏳ pending
A11y audit	⏳ pending
Design system audit	⏳ pending

See individual comments above for details. This rollup updates automatically.

## Pipeline Health ### Build + CI gates | Gate | Status | | --- | --- | | Vercel build (Preview) | ✅ pass | | CI: Lint | ✅ pass | | CI: Schema map fresh | ❌ skipped | | Preview smoke | ✅ pass | | Visual diff | ✅ pass | _Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build)._ ### Role reports | Role | Status | | --- | --- | | Reviewer report | ⏳ pending | | A11y audit | ⏳ pending | | Design system audit | ⏳ pending | See individual comments above for details. This rollup updates automatically.

github-actions[bot] commented

2026-05-28 15:23:27 -04:00

(Migrated from github.com)

Visual Diff

Screenshots and diffs uploaded as artifacts: view run

If intentional changes: update snapshots locally with npx playwright test --project=visual --update-snapshots and commit.

## Visual Diff Screenshots and diffs uploaded as artifacts: [view run](https://github.com/varutasu/tcg-vault/actions/runs/26596942058) If intentional changes: update snapshots locally with `npx playwright test --project=visual --update-snapshots` and commit.