rstillwell/deckhearth
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions 10

fix(scanner): close redesign a11y audit findings #45

Merged
varutasu merged 1 commit from fix/scanner-redesign-a11y-fixes into main 2026-05-27 15:22:18 -04:00
Conversation 3 Commits 1 Files changed 6 +162 -36
varutasu commented 2026-05-27 15:13:16 -04:00 (Migrated from github.com)
Copy link

Summary

  • Adds lib/use-focus-trap.js and wires it to the disambiguation dialog + create-collection modal
  • Labels icon-only camera controls, per-card/bulk <select>s, and remove/clear buttons
  • Ownership badge uses role="status"; scan queue uses <ul>/<li> with polite live count

Closes P1 follow-up from audit-redesign-scanner-flow-44.

Test plan

  • Tab through disambiguation modal — focus stays inside; restores on close
  • Tab through create-collection modal — same
  • VoiceOver/NVDA: ownership badge announces "You already own N…"
  • Bulk toolbar selects announce purpose without visible labels
  • CI: vitest 21/21 + visual diff (scanner page touched)

Made with Cursor

## Summary - Adds `lib/use-focus-trap.js` and wires it to the disambiguation dialog + create-collection modal - Labels icon-only camera controls, per-card/bulk `<select>`s, and remove/clear buttons - Ownership badge uses `role="status"`; scan queue uses `<ul>`/`<li>` with polite live count Closes P1 follow-up from `audit-redesign-scanner-flow-44`. ## Test plan - [ ] Tab through disambiguation modal — focus stays inside; restores on close - [ ] Tab through create-collection modal — same - [ ] VoiceOver/NVDA: ownership badge announces "You already own N…" - [ ] Bulk toolbar selects announce purpose without visible labels - [ ] CI: vitest 21/21 + visual diff (scanner page touched) Made with [Cursor](https://cursor.com)
vercel[bot] commented 2026-05-27 15:13:22 -04:00 (Migrated from github.com)
Copy link

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tcg-vault Ready Ready Preview, Comment May 27, 2026 7:13pm

Request Review

[vc]: #uYNTjXqxhuloknNbdMLzb8Aopdwf8gsxHrJmb2Q/i9g=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMvdGNnLXZhdWx0LzIxNDVINTdza2VyeWU3Ym9WamRDMzZyNDlXUlQiLCJwcmV2aWV3VXJsIjoidGNnLXZhdWx0LWdpdC1maXgtc2Nhbm5lci1yZS05YTMzMGYtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoidGNnLXZhdWx0LWdpdC1maXgtc2Nhbm5lci1yZS05YTMzMGYtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAifSwicm9vdERpcmVjdG9yeSI6bnVsbH1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj00NSJ9 The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/2145H57skerye7boVjdC36r49WRT) | [Preview](https://tcg-vault-git-fix-scanner-re-9a330f-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-fix-scanner-re-9a330f-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | May 27, 2026 7:13pm | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=45" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>
github-actions[bot] commented 2026-05-27 15:13:29 -04:00 (Migrated from github.com)
Copy link

Pipeline Health

Build + CI gates

Gate Status
Vercel build (Preview) ✅ pass
CI: Lint ✅ pass
CI: Schema map fresh ❌ skipped
Preview smoke ✅ pass
Visual diff ✅ pass

Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build).

Role reports

Role Status
Reviewer report ⏳ pending
A11y audit ⏳ pending
Design system audit ⏳ pending

See individual comments above for details. This rollup updates automatically.

<!-- pipeline-rollup --> ## Pipeline Health ### Build + CI gates | Gate | Status | | --- | --- | | Vercel build (Preview) | ✅ pass | | CI: Lint | ✅ pass | | CI: Schema map fresh | ❌ skipped | | Preview smoke | ✅ pass | | Visual diff | ✅ pass | _Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build)._ ### Role reports | Role | Status | | --- | --- | | Reviewer report | ⏳ pending | | A11y audit | ⏳ pending | | Design system audit | ⏳ pending | See individual comments above for details. This rollup updates automatically.
github-actions[bot] commented 2026-05-27 15:14:25 -04:00 (Migrated from github.com)
Copy link

Visual Diff

Screenshots and diffs uploaded as artifacts: view run

If intentional changes: update snapshots locally with npx playwright test --project=visual --update-snapshots and commit.

## Visual Diff Screenshots and diffs uploaded as artifacts: [view run](https://github.com/varutasu/tcg-vault/actions/runs/26533009993) If intentional changes: update snapshots locally with `npx playwright test --project=visual --update-snapshots` and commit.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-context-drift

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
agent-context-drift
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rstillwell/deckhearth#45
No description provided.
Delete branch "fix/scanner-redesign-a11y-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?