fix(auth): scanner redirect + admin card-editor crash #36

Merged

varutasu merged 1 commit from fix/auth-loading-and-admin-hooks into main

2026-05-27 13:36:59 -04:00

varutasu commented

2026-05-27 13:35:35 -04:00

(Migrated from github.com)

Summary

Scanner false logout: wait for useAuth() loading to finish before redirecting to /login (matches dashboard pattern).
Admin card-editor crash: remove mounted early return that placed hooks after a conditional return (Rules of Hooks violation → Next.js application error on admin login redirect).
Admin card-import: same hooks fix (latent; page already uses dynamic({ ssr: false })).

Test plan

npm run test:run — 21/21
Admin login → lands on /admin/card-editor without application error
Navigate to /scanner while logged in → stays on scanner (no bounce to login)

Made with Cursor

## Summary - **Scanner false logout:** wait for `useAuth()` loading to finish before redirecting to `/login` (matches dashboard pattern). - **Admin card-editor crash:** remove `mounted` early return that placed hooks after a conditional return (Rules of Hooks violation → Next.js application error on admin login redirect). - **Admin card-import:** same hooks fix (latent; page already uses `dynamic({ ssr: false })`). ## Test plan - [x] `npm run test:run` — 21/21 - [ ] Admin login → lands on `/admin/card-editor` without application error - [ ] Navigate to `/scanner` while logged in → stays on scanner (no bounce to login) Made with [Cursor](https://cursor.com)

vercel[bot] commented

2026-05-27 13:35:38 -04:00

(Migrated from github.com)

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tcg-vault	Ready	Preview, Comment	May 27, 2026 5:35pm

[vc]: #vkwR1+zgsfH9ZbmU0fbRyxj2/KjI/LBeRAq95K3sj7g=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMvdGNnLXZhdWx0LzZpVTRLdkdRWUpQZG1DREIyY3lVS2JpU1ZLVFAiLCJwcmV2aWV3VXJsIjoidGNnLXZhdWx0LWdpdC1maXgtYXV0aC1sb2FkaS1iM2QxZDgtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoidGNnLXZhdWx0LWdpdC1maXgtYXV0aC1sb2FkaS1iM2QxZDgtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAifSwicm9vdERpcmVjdG9yeSI6bnVsbH1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj0zNiJ9 The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/6iU4KvGQYJPdmCDB2cyUKbiSVKTP) | [Preview](https://tcg-vault-git-fix-auth-loadi-b3d1d8-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-fix-auth-loadi-b3d1d8-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | May 27, 2026 5:35pm | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=36" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>

github-actions[bot] commented

2026-05-27 13:35:48 -04:00

(Migrated from github.com)

Pipeline Health

Build + CI gates

Gate	Status
Vercel build (Preview)	✅ pass
CI: Lint	✅ pass
CI: Schema map fresh	❌ skipped
Preview smoke	✅ pass
Visual diff	✅ pass

Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build).

Role reports

Role	Status
Reviewer report	⏳ pending
A11y audit	⏳ pending
Design system audit	⏳ pending

See individual comments above for details. This rollup updates automatically.

## Pipeline Health ### Build + CI gates | Gate | Status | | --- | --- | | Vercel build (Preview) | ✅ pass | | CI: Lint | ✅ pass | | CI: Schema map fresh | ❌ skipped | | Preview smoke | ✅ pass | | Visual diff | ✅ pass | _Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build)._ ### Role reports | Role | Status | | --- | --- | | Reviewer report | ⏳ pending | | A11y audit | ⏳ pending | | Design system audit | ⏳ pending | See individual comments above for details. This rollup updates automatically.

github-actions[bot] commented

2026-05-27 13:36:48 -04:00

(Migrated from github.com)

Visual Diff

Screenshots and diffs uploaded as artifacts: view run

If intentional changes: update snapshots locally with npx playwright test --project=visual --update-snapshots and commit.

## Visual Diff Screenshots and diffs uploaded as artifacts: [view run](https://github.com/varutasu/tcg-vault/actions/runs/26527904552) If intentional changes: update snapshots locally with `npx playwright test --project=visual --update-snapshots` and commit.