docs: post-convoy cleanup for 7-convoy 2026-05-26 wave #33

Merged

varutasu merged 1 commit from convoy/docs-cleanup-7-wave into main

2026-05-27 00:15:21 -04:00

varutasu commented

2026-05-27 00:12:59 -04:00

(Migrated from github.com)

Summary

Doc-only commit. NO source-code changes. Pure post-convoy documentation cleanup for the 7-convoy multitask wave that merged 2026-05-26 (UTC mergedAt times all 2026-05-27 03:51-04:02Z):

PR #26 tighten-visual-diff-path-filter (P3, ba95462) — !pages/api/** exclusion added to visual-diff.yml. PR #30 was the first API-only PR post-merge; Screenshot diff did NOT trigger — empirical confirmation that the exclusion fires as documented.
PR #27 purge-weak-creds-from-helpers (P2, 5f2b234) — scripts/create-test-users.js + TESTING_GUIDE.md swept. Single TEST_USERS_PASSWORD env var; closes the umbrella purge-weak-creds-from-helpers.
PR #28 cleanup-mobile-nav-dead-props (P3, 171f5af) — single dead user prop removed from MobileNavigation + its lone caller.
PR #29 lint-against-cjs-in-esm-scripts (P3, 13d6210) — ESLint no-restricted-syntax rule scoped to scripts/**/*.js; would have caught both setup-neon-db.js and reset-db.js pre-fix bugs.
PR #30 single-sql-client (P1 #8 RESOLVED, c403ea4) — lib/database.js deleted; 2 callers migrated to @vercel/postgres tagged templates.
PR #31 single-auth-provider (P1 #9 RESOLVED, 0668b0c) — lib/auth-context.js + lib/admin-auth.js deleted; 7 source files swept; verify-roundtrip count reduced 3→1 on card/[id].js. Lint baseline 128 → 125 (new baseline).
PR #32 migration-tool (P1 #11 RESOLVED, de9f334) — node-pg-migrate@^8 adopted; initial schema backfilled to migrations/1779853647564_initial-schema.js; setup-neon-db.js now owns env validation + migration spawn + admin seed only.

Milestone: 5 of 6 P1 quality items RESOLVED. Only fix-lint-baseline (P1 #11.5) remains in the P1 lane.

Files changed (9)

.convoys/ship-readiness.md — A.1 flipped 5 queue entries to RESOLVED; A.2 flipped § P1 #8, #9, #11 to RESOLVED-style; A.3 added 7 new queued follow-ups (purge-quick-login-from-loginpage, purge-neondatabase-serverless-fully, wire-migrate-into-ci, reconcile-historical-add-scripts, retire-graveyard-scripts-after-audit, audit-node-pg-migrate-transitive-deps, add-migration-template); A.4 updated the § Status summary milestone block; A.5 flipped § Launch sequence steps 7/8/9 to RESOLVED-style.
.convoys/tighten-visual-diff-path-filter.md — § As-shipped filled in (records the PR #30 empirical confirmation).
.convoys/purge-weak-creds-from-helpers.md — § As-shipped filled in (closes the umbrella).
.convoys/cleanup-mobile-nav-dead-props.md — § As-shipped filled in.
.convoys/lint-against-cjs-in-esm-scripts.md — § As-shipped filled in (negative test verified).
.convoys/single-sql-client.md — § As-shipped filled in.
.convoys/single-auth-provider.md — § As-shipped filled in.
.convoys/migration-tool.md — § As-shipped supplemented with squash SHA + PR # + mergedAt + CI gate outcomes (the implementer had already written a detailed as-shipped record; this adds the per-spec citation header).
AGENTS.md — § 1 Data line refreshed; § 2 Architecture quick reference Auth + DB libs row refreshed; § 3 "DB access" bullet refreshed (legacy lib/database.js warning replaced with the post-deletion guidance for the remaining @neondatabase/serverless scripts/** callers); § 3 "Auth (client)" bullet supplemented with the direct-fetch login flow note + PR # citation; § 4 Gotcha #1 flipped to RESOLVED (entry kept, not renumbered, mirroring the Gotcha #2/#3/#4/#5/#6/#8 pattern). Gotchas #9, #10, #11, #12 untouched (all still accurate).

Constraints respected

No source code touched (no pages/**, no components/**, no lib/**, no scripts/**, no migrations/**, no .github/workflows/**).
No tests modified.
No frontmatter classification fields changed.
No gotchas renumbered in AGENTS.md.
No deps bumped.

Test plan

npm run lint → exit 1 with 125 problems (baseline preserved post-PR-#31).
npm run test:run → 21/21 pass.
CI on this PR: Lint + Vitest + Playwright smoke + forbidden-* gates green.
Screenshot diff should NOT trigger on this PR — diff is .convoys/** + AGENTS.md, neither matches the visual-diff paths: filter.

Made with Cursor

## Summary Doc-only commit. NO source-code changes. Pure post-convoy documentation cleanup for the 7-convoy multitask wave that merged 2026-05-26 (UTC mergedAt times all 2026-05-27 03:51-04:02Z): - PR #26 `tighten-visual-diff-path-filter` (P3, `ba95462`) — `!pages/api/**` exclusion added to `visual-diff.yml`. PR #30 was the first API-only PR post-merge; `Screenshot diff` did NOT trigger — empirical confirmation that the exclusion fires as documented. - PR #27 `purge-weak-creds-from-helpers` (P2, `5f2b234`) — `scripts/create-test-users.js` + `TESTING_GUIDE.md` swept. Single `TEST_USERS_PASSWORD` env var; closes the umbrella `purge-weak-creds-from-helpers`. - PR #28 `cleanup-mobile-nav-dead-props` (P3, `171f5af`) — single dead `user` prop removed from `MobileNavigation` + its lone caller. - PR #29 `lint-against-cjs-in-esm-scripts` (P3, `13d6210`) — ESLint `no-restricted-syntax` rule scoped to `scripts/**/*.js`; would have caught both `setup-neon-db.js` and `reset-db.js` pre-fix bugs. - PR #30 `single-sql-client` (P1 #8 RESOLVED, `c403ea4`) — `lib/database.js` deleted; 2 callers migrated to `@vercel/postgres` tagged templates. - PR #31 `single-auth-provider` (P1 #9 RESOLVED, `0668b0c`) — `lib/auth-context.js` + `lib/admin-auth.js` deleted; 7 source files swept; verify-roundtrip count reduced 3→1 on `card/[id].js`. **Lint baseline 128 → 125** (new baseline). - PR #32 `migration-tool` (P1 #11 RESOLVED, `de9f334`) — `node-pg-migrate@^8` adopted; initial schema backfilled to `migrations/1779853647564_initial-schema.js`; `setup-neon-db.js` now owns env validation + migration spawn + admin seed only. **Milestone:** 5 of 6 P1 quality items RESOLVED. Only `fix-lint-baseline` (P1 #11.5) remains in the P1 lane. ## Files changed (9) - `.convoys/ship-readiness.md` — A.1 flipped 5 queue entries to RESOLVED; A.2 flipped § P1 #8, #9, #11 to RESOLVED-style; A.3 added 7 new queued follow-ups (`purge-quick-login-from-loginpage`, `purge-neondatabase-serverless-fully`, `wire-migrate-into-ci`, `reconcile-historical-add-scripts`, `retire-graveyard-scripts-after-audit`, `audit-node-pg-migrate-transitive-deps`, `add-migration-template`); A.4 updated the § Status summary milestone block; A.5 flipped § Launch sequence steps 7/8/9 to RESOLVED-style. - `.convoys/tighten-visual-diff-path-filter.md` — § As-shipped filled in (records the PR #30 empirical confirmation). - `.convoys/purge-weak-creds-from-helpers.md` — § As-shipped filled in (closes the umbrella). - `.convoys/cleanup-mobile-nav-dead-props.md` — § As-shipped filled in. - `.convoys/lint-against-cjs-in-esm-scripts.md` — § As-shipped filled in (negative test verified). - `.convoys/single-sql-client.md` — § As-shipped filled in. - `.convoys/single-auth-provider.md` — § As-shipped filled in. - `.convoys/migration-tool.md` — § As-shipped supplemented with squash SHA + PR # + mergedAt + CI gate outcomes (the implementer had already written a detailed as-shipped record; this adds the per-spec citation header). - `AGENTS.md` — § 1 Data line refreshed; § 2 Architecture quick reference Auth + DB libs row refreshed; § 3 "DB access" bullet refreshed (legacy `lib/database.js` warning replaced with the post-deletion guidance for the remaining `@neondatabase/serverless` `scripts/**` callers); § 3 "Auth (client)" bullet supplemented with the direct-fetch login flow note + PR # citation; § 4 Gotcha #1 flipped to RESOLVED (entry kept, not renumbered, mirroring the Gotcha #2/#3/#4/#5/#6/#8 pattern). Gotchas #9, #10, #11, #12 untouched (all still accurate). ## Constraints respected - No source code touched (no `pages/**`, no `components/**`, no `lib/**`, no `scripts/**`, no `migrations/**`, no `.github/workflows/**`). - No tests modified. - No frontmatter `classification` fields changed. - No gotchas renumbered in AGENTS.md. - No deps bumped. ## Test plan - [x] `npm run lint` → exit 1 with **125 problems** (baseline preserved post-PR-#31). - [x] `npm run test:run` → **21/21 pass**. - [ ] CI on this PR: Lint + Vitest + Playwright smoke + forbidden-* gates green. - [ ] `Screenshot diff` should NOT trigger on this PR — diff is `.convoys/**` + `AGENTS.md`, neither matches the visual-diff `paths:` filter. Made with [Cursor](https://cursor.com)

vercel[bot] commented

2026-05-27 00:13:05 -04:00

(Migrated from github.com)

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tcg-vault	Ready	Preview, Comment	May 27, 2026 4:13am

[vc]: #s6jJY3OGSZBTQZhB0LJ4ycwh5un53nvuqHPuM6gGjF4=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJ0Y2ctdmF1bHQtZ2l0LWNvbnZveS1kb2NzLWNsLWYyOWFlOS1yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMudmVyY2VsLmFwcCJ9LCJpbnNwZWN0b3JVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzL3RjZy12YXVsdC94Q0EzYVVvS3Y1UExpMXRxcWdUc2JTUVlveWpSIiwicHJldmlld1VybCI6InRjZy12YXVsdC1naXQtY29udm95LWRvY3MtY2wtZjI5YWU5LXJhbmRhbGwtc3RpbGx3ZWxscy1wcm9qZWN0cy52ZXJjZWwuYXBwIiwibmV4dENvbW1pdFN0YXR1cyI6IkRFUExPWUVEIn1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj0zMyJ9 The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/xCA3aUoKv5PLi1tqqgTsbSQYoyjR) | [Preview](https://tcg-vault-git-convoy-docs-cl-f29ae9-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-convoy-docs-cl-f29ae9-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | May 27, 2026 4:13am | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=33" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>

github-actions[bot] commented

2026-05-27 00:13:13 -04:00

(Migrated from github.com)

Pipeline Health

Build + CI gates

Gate	Status
Vercel build (Preview)	✅ pass
CI: Lint	✅ pass
CI: Schema map fresh	❌ skipped
Preview smoke	✅ pass
Visual diff	⏭ skipped or pending

Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build).

Role reports

Role	Status
Reviewer report	⏳ pending
A11y audit	⏳ pending
Design system audit	⏳ pending

See individual comments above for details. This rollup updates automatically.

## Pipeline Health ### Build + CI gates | Gate | Status | | --- | --- | | Vercel build (Preview) | ✅ pass | | CI: Lint | ✅ pass | | CI: Schema map fresh | ❌ skipped | | Preview smoke | ✅ pass | | Visual diff | ⏭ skipped or pending | _Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build)._ ### Role reports | Role | Status | | --- | --- | | Reviewer report | ⏳ pending | | A11y audit | ⏳ pending | | Design system audit | ⏳ pending | See individual comments above for details. This rollup updates automatically.