rstillwell/deckhearth
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Wire scanner feedback toasts and restore rescan uploads #157

Merged
rstillwell merged 1 commit from fix/scanner-feedback-rescan into main 2026-09-08 20:08:02 -04:00
Conversation 0 Commits 1 Files changed 3 +37 -14
rstillwell commented 2026-09-08 20:06:46 -04:00
Owner
Copy link

Summary

  • Show scan notices and camera/identify errors in the scanner page toast so feedback is visible during capture and identification.
  • Patch scanImageUrl after background upload completes so rescans use the uploaded image URL.
  • Fix debug upload logging for clearer scanner pipeline diagnostics.

Test plan

  • npm run test:run -- test/lib/scanner-session.test.js
  • Open scanner, trigger a scan notice and confirm it appears in the page toast.
  • Rescan a card after background upload finishes and confirm identification uses the updated image URL.
  • Enable scanner debug mode and verify upload logging is correct.
## Summary - Show scan notices and camera/identify errors in the scanner page toast so feedback is visible during capture and identification. - Patch `scanImageUrl` after background upload completes so rescans use the uploaded image URL. - Fix debug upload logging for clearer scanner pipeline diagnostics. ## Test plan - [ ] `npm run test:run -- test/lib/scanner-session.test.js` - [ ] Open scanner, trigger a scan notice and confirm it appears in the page toast. - [ ] Rescan a card after background upload finishes and confirm identification uses the updated image URL. - [ ] Enable scanner debug mode and verify upload logging is correct.
rstillwell added 1 commit 2026-09-08 20:06:58 -04:00
Wire scanner feedback toasts and restore rescan uploads.
Some checks failed
CI / Lint (pull_request) Has been cancelled
Details
CI / Schema map up to date (pull_request) Has been cancelled
Details
CI / Forbidden patterns (9 checks) (pull_request) Has been cancelled
Details
CI / Migrations apply (node-pg-migrate) (pull_request) Has been cancelled
Details
Visual diff / Should run? (pull_request) Has been cancelled
Details
CI / Unit tests (vitest) (pull_request) Has been cancelled
Details
Convoy metrics gate / Require role-event telemetry on convoy PRs (pull_request) Has been cancelled
Details
PR Health rollup / Aggregate gate status (pull_request) Has been cancelled
Details
Preview smoke / Should run? (pull_request) Has been cancelled
Details
Visual diff / Screenshot diff (pull_request) Has been cancelled
Details
Preview smoke / Playwright smoke (pull_request) Has been cancelled
Details
e733dc5a13 
Show scan notices and camera/identify errors in the page toast, patch scanImageUrl after background upload completes, and fix debug upload logging.

Co-authored-by: Cursor <cursoragent@cursor.com>
rstillwell merged commit 70be99421d into main 2026-09-08 20:08:02 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-context-drift

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
agent-context-drift
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rstillwell/deckhearth#157
No description provided.
Delete branch "fix/scanner-feedback-rescan"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?