ci: slash GitHub Actions minutes via paths-ignore + consolidation + caching #126

Merged

varutasu merged 1 commit from slash-ci-minutes into main

2026-06-04 17:40:37 -04:00

Author	SHA1	Message	Date
Randall Stillwell	1b6d0d58db	ci: slash GitHub Actions minutes via paths-ignore + consolidation + caching Standalone infrastructure PR (no convoy ceremony needed — single-file scope). Triggered by the GitHub Actions billing block that gated PRs #124 + #125 today. Three layers of savings applied per the user's max-savings option: 1. paths-ignore on ci.yml + preview-smoke.yml - Doc-only PRs (.convoys/, /.md, docs/, AGENTS.md, .cursor/, README.md) now trigger ZERO Actions jobs. - Vercel still builds (it's not on the Actions billing). - visual-diff.yml unchanged — it was already cost-conscious via a positive paths: allowlist (pages/, components/, styles/, etc.). 2. Consolidate 6 grep-only forbidden- jobs into 1 - Previously 6 independent jobs each ran their own actions/checkout (~3s × 6 = 18s of redundant checkout). - Merged into a single forbidden-patterns job with 6 sequential ::group:: sections, one FAIL flag at the bottom — preserves "see all violations in one run" diagnostic behavior. Per-file ::error file=...::msg annotations work the same way. - Removed jobs: forbidden-endpoints, forbidden-cors-headers, forbidden-client-side-llm-keys, forbidden-modal-shell-without-primitive, forbidden-deprecated-color-aliases, forbidden-stale-strings. - pr-health-rollup.yml only looks up "Lint" and "Schema map up to date" by name — unaffected. 3. Cache node_modules + Playwright browsers - actions/cache@v4 for node_modules keyed by package-lock.json hash, applied to lint / test / migrate / preview-smoke / visual-diff. Cuts npm ci from ~30-45s to ~3-5s on cache hit. setup-node@v4's built-in cache: npm stays (caches ~/.npm) — both layered. - actions/cache@v4 for ~/.cache/ms-playwright keyed by the resolved @playwright/test version. Cache invalidates on any Playwright version bump. On cache hit, only system deps install runs (npx playwright install-deps chromium) — saves ~15-25s/run. AGENTS.md updates: - § 6 Testing § CI behavior: appended "CI minute optimizations" subsection documenting all three layers. - § Product vocabulary table caption: updated "CI job forbidden-stale-strings" reference to "CI check Forbidden patterns (6 checks) → Check 6/6" with a historical pointer. - Gotcha #5: updated the standalone forbidden-endpoints reference similarly. Estimated savings per typical convoy mix (~30% doc PRs based on repo history): - Doc-only PRs: 100% reduction (was ~6-7 min, now 0 Actions min). - Code-touching PRs: ~30-50% reduction (cache hits for npm + Playwright + no redundant 6× checkout). - Weighted average: ~50-60% reduction. This is short of the 70-80% I floated in chat — the real ceiling is limited by lint / vitest / migrate / Playwright runtime itself, all of which are kept on code-touching PRs (they're high-signal). Verification: - All 3 workflow YAMLs parse (python3 -c "yaml.safe_load(...)"). - npm run lint passes (1 pre-existing unrelated warning). - npm run test:run: 118/118 tests pass. - forbidden-patterns logic is byte-equivalent to the 6 original jobs' bash bodies — the differences are: per-check ::group::/::endgroup:: framing, a shared FAIL flag instead of per-job exit 1, and renamed local arrays (FOUND → LLM_FOUND / MODAL_FOUND / STRING_FOUND) to avoid clobbering across the single job's scope. Co-authored-by: Cursor <cursoragent@cursor.com>	2026-06-04 16:32:29 -05:00

Author

SHA1

Message

Date

Randall Stillwell

1b6d0d58db

ci: slash GitHub Actions minutes via paths-ignore + consolidation + caching

Standalone infrastructure PR (no convoy ceremony needed — single-file
scope). Triggered by the GitHub Actions billing block that gated
PRs #124 + #125 today.

Three layers of savings applied per the user's max-savings option:

1. paths-ignore on ci.yml + preview-smoke.yml
   - Doc-only PRs (.convoys/**, **/*.md, docs/**, AGENTS.md,
     .cursor/**, README.md) now trigger ZERO Actions jobs.
   - Vercel still builds (it's not on the Actions billing).
   - visual-diff.yml unchanged — it was already cost-conscious via a
     positive paths: allowlist (pages/**, components/**, styles/**,
     etc.).

2. Consolidate 6 grep-only forbidden-* jobs into 1
   - Previously 6 independent jobs each ran their own
     actions/checkout (~3s × 6 = 18s of redundant checkout).
   - Merged into a single forbidden-patterns job with 6 sequential
     ::group:: sections, one FAIL flag at the bottom — preserves
     "see all violations in one run" diagnostic behavior. Per-file
     ::error file=...::msg annotations work the same way.
   - Removed jobs: forbidden-endpoints, forbidden-cors-headers,
     forbidden-client-side-llm-keys,
     forbidden-modal-shell-without-primitive,
     forbidden-deprecated-color-aliases, forbidden-stale-strings.
   - pr-health-rollup.yml only looks up "Lint" and "Schema map up to
     date" by name — unaffected.

3. Cache node_modules + Playwright browsers
   - actions/cache@v4 for node_modules keyed by package-lock.json
     hash, applied to lint / test / migrate / preview-smoke /
     visual-diff. Cuts npm ci from ~30-45s to ~3-5s on cache hit.
     setup-node@v4's built-in cache: npm stays (caches ~/.npm) —
     both layered.
   - actions/cache@v4 for ~/.cache/ms-playwright keyed by the
     resolved @playwright/test version. Cache invalidates on any
     Playwright version bump. On cache hit, only system deps install
     runs (npx playwright install-deps chromium) — saves ~15-25s/run.

AGENTS.md updates:
- § 6 Testing § CI behavior: appended "CI minute optimizations" subsection
  documenting all three layers.
- § Product vocabulary table caption: updated "CI job
  forbidden-stale-strings" reference to "CI check Forbidden patterns
  (6 checks) → Check 6/6" with a historical pointer.
- Gotcha #5: updated the standalone forbidden-endpoints reference
  similarly.

Estimated savings per typical convoy mix (~30% doc PRs based on
repo history):
- Doc-only PRs: 100% reduction (was ~6-7 min, now 0 Actions min).
- Code-touching PRs: ~30-50% reduction (cache hits for npm + Playwright +
  no redundant 6× checkout).
- Weighted average: ~50-60% reduction.

This is short of the 70-80% I floated in chat — the real ceiling is
limited by lint / vitest / migrate / Playwright runtime itself, all of
which are kept on code-touching PRs (they're high-signal).

Verification:
- All 3 workflow YAMLs parse (python3 -c "yaml.safe_load(...)").
- npm run lint passes (1 pre-existing unrelated warning).
- npm run test:run: 118/118 tests pass.
- forbidden-patterns logic is byte-equivalent to the 6 original jobs'
  bash bodies — the differences are: per-check ::group::/::endgroup::
  framing, a shared FAIL flag instead of per-job exit 1, and renamed
  local arrays (FOUND → LLM_FOUND / MODAL_FOUND / STRING_FOUND) to
  avoid clobbering across the single job's scope.

Co-authored-by: Cursor <cursoragent@cursor.com>

2026-06-04 16:32:29 -05:00