rstillwell/deckhearth
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions 10

refactor(bulk-toolbar): migrate to .glass-panel-strong + token sweep (Brief 4) #125

Merged
varutasu merged 1 commit from brief-4-bulk-selection-toolbar into main 2026-06-04 17:25:17 -04:00
Conversation 1 Commits 1 Files changed 1 +30 -10
varutasu commented 2026-06-04 16:39:15 -04:00 (Migrated from github.com)
Copy link

Brief 4 of unify-glass-panel-surfaces convoy. The bulk-select toolbar was a critical dark-mode bug (bg-white invisible against dark backgrounds); migrating to .glass-panel-strong is both a unification win and a correctness fix.

See .convoys/unify-glass-panel-surfaces/brief-4-bulk-selection-toolbar.md for the full brief.

Files changed

  • components/BulkSelectionToolbar.js — outer toolbar + interior token sweep. +30/-10.

Highlights

  • Outer toolbar: bg-white rounded-xl ... → glass-panel-strong rounded-2xl + inline boxShadow: var(--rim-light-inner), var(--elevation-pronounced).
  • More-actions dropdown: bg-white rounded-lg ... → glass-panel-strong rounded-xl (no inline override).
  • Token sweep: all text-gray-* / hover:bg-gray-* / text-red-* / border-gray-* / bg-gray-300 swapped to CSS vars + nav-item-hover.
  • Destructive 'Delete Selected' uses rgb(239, 68, 68) literal (documented Brief 4 fallback — --accent-danger token doesn't exist yet).
  • 3 colored quick-action buttons (Collection / Deck / My Collection) UNCHANGED (out of scope).

Acceptance criteria

  • rg 'text-gray-|bg-gray-|hover:bg-gray-|text-red-|hover:bg-red-|border-gray-' components/BulkSelectionToolbar.js returns 0 matches.
  • npm run lint passes (1 pre-existing unrelated warning).
  • npm run test:run: 116/116 tests pass.

Test plan (manual — dark mode is critical)

  • Bulk-select on /my-cards. Light + dark both render with corner catch-lights + proper contrast.
  • More-actions dropdown opens with .glass-panel-strong treatment.
  • Delete Selected reads red on default, ember on hover (nav-item-hover).
  • Attach before/after dark-mode screenshots.

Related

  • Convoy: .convoys/unify-glass-panel-surfaces.md
  • Brief: .convoys/unify-glass-panel-surfaces/brief-4-bulk-selection-toolbar.md
  • Brief 1 (primitive): PR #123 (merged); Brief 3 (popovers): PR #124 (open).

Made with Cursor

Brief 4 of unify-glass-panel-surfaces convoy. The bulk-select toolbar was a critical dark-mode bug (bg-white invisible against dark backgrounds); migrating to .glass-panel-strong is both a unification win and a correctness fix. See `.convoys/unify-glass-panel-surfaces/brief-4-bulk-selection-toolbar.md` for the full brief. ## Files changed - `components/BulkSelectionToolbar.js` — outer toolbar + interior token sweep. +30/-10. ## Highlights - Outer toolbar: `bg-white rounded-xl ...` → `glass-panel-strong rounded-2xl` + inline `boxShadow: var(--rim-light-inner), var(--elevation-pronounced)`. - More-actions dropdown: `bg-white rounded-lg ...` → `glass-panel-strong rounded-xl` (no inline override). - Token sweep: all `text-gray-*` / `hover:bg-gray-*` / `text-red-*` / `border-gray-*` / `bg-gray-300` swapped to CSS vars + `nav-item-hover`. - Destructive 'Delete Selected' uses `rgb(239, 68, 68)` literal (documented Brief 4 fallback — `--accent-danger` token doesn't exist yet). - 3 colored quick-action buttons (Collection / Deck / My Collection) UNCHANGED (out of scope). ## Acceptance criteria - [x] `rg 'text-gray-|bg-gray-|hover:bg-gray-|text-red-|hover:bg-red-|border-gray-' components/BulkSelectionToolbar.js` returns 0 matches. - [x] `npm run lint` passes (1 pre-existing unrelated warning). - [x] `npm run test:run`: 116/116 tests pass. ## Test plan (manual — dark mode is critical) - [ ] Bulk-select on /my-cards. Light + dark both render with corner catch-lights + proper contrast. - [ ] More-actions dropdown opens with .glass-panel-strong treatment. - [ ] Delete Selected reads red on default, ember on hover (nav-item-hover). - [ ] Attach before/after dark-mode screenshots. ## Related - Convoy: `.convoys/unify-glass-panel-surfaces.md` - Brief: `.convoys/unify-glass-panel-surfaces/brief-4-bulk-selection-toolbar.md` - Brief 1 (primitive): PR #123 (merged); Brief 3 (popovers): PR #124 (open). Made with [Cursor](https://cursor.com)
vercel[bot] commented 2026-06-04 16:39:21 -04:00 (Migrated from github.com)
Copy link

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tcg-vault Ready Ready Preview, Comment Jun 4, 2026 8:39pm

Request Review

[vc]: #jOv0aCwAn8OJlxuRNkGMrjmFYUW+jSPmYedwmC5oGV4=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJ0Y2ctdmF1bHQtZ2l0LWJyaWVmLTQtYnVsay1zLTUzOGY3Yi1yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMudmVyY2VsLmFwcCJ9LCJpbnNwZWN0b3JVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzL3RjZy12YXVsdC9EWkZtc1JMaHZGYXJlQ2l0VnhBZllhYkQ2N0NUIiwicHJldmlld1VybCI6InRjZy12YXVsdC1naXQtYnJpZWYtNC1idWxrLXMtNTM4ZjdiLXJhbmRhbGwtc3RpbGx3ZWxscy1wcm9qZWN0cy52ZXJjZWwuYXBwIiwibmV4dENvbW1pdFN0YXR1cyI6IkRFUExPWUVEIn1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj0xMjUifQ== The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/DZFmsRLhvFareCitVxAfYabD67CT) | [Preview](https://tcg-vault-git-brief-4-bulk-s-538f7b-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-brief-4-bulk-s-538f7b-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | Jun 4, 2026 8:39pm | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=125" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-context-drift

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
agent-context-drift
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rstillwell/deckhearth#125
No description provided.
Delete branch "brief-4-bulk-selection-toolbar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?