refactor(auth): migrate login + signup form cards to .glass-panel-strong (Brief 2) #121

Merged

varutasu merged 1 commit from brief-2-auth-form-cards-glass-panel-strong into main

2026-06-04 16:30:26 -04:00

varutasu commented

2026-06-04 15:12:33 -04:00

(Migrated from github.com)

Summary

Brief 2 of unify-glass-panel-surfaces. Migrates the login + signup form-card containers from handrolled rgba(--bg-secondary-rgb, 0.85) + backdrop-blur-sm Tailwind glass imitation to the canonical .glass-panel-strong rounded-2xl p-8 className.

These are the first surfaces a new user sees; aligning them with the rest of the app's surface vocabulary means corner catch-lights, system blur tier, and the gradient border — not a handrolled approximation.

Files changed

pages/login.js — form-card <div> className/style swap.
pages/signup.js — same swap on the symmetric form-card <div>.

Net diff: +2 / -14. Pure className → className migration.

Diff (representative)

- <div
-   className="p-8 rounded-2xl shadow-2xl backdrop-blur-sm border border-opacity-20"
-   style={{
-     backgroundColor: 'rgba(var(--bg-secondary-rgb), 0.85)',
-     borderColor: 'var(--border)',
-   }}
- >
+ <div className="glass-panel-strong rounded-2xl p-8">

Acceptance criteria

pages/login.js form-card <div> uses className="glass-panel-strong rounded-2xl p-8" and no inline backgroundColor/borderColor style.
pages/signup.js form-card <div> uses className="glass-panel-strong rounded-2xl p-8" and no inline backgroundColor/borderColor style.
All form fields, labels, buttons, error banners, footer links unchanged (children are byte-identical).
No edits to other files. No token additions in styles/globals.css. No new components.
npm run lint passes (one pre-existing unrelated warning in components/CollectionsPageView.js).

Test plan

Visit /login in light + dark mode; verify the form card renders with corner catch-lights and theme-correct background.
Visit /signup in light + dark mode; same verification.
Submit invalid credentials; verify the error banner still renders properly inside the new container.
Verify the existing tests/smoke/auth.spec.js continues to pass (no edits required).

Convoy: .convoys/unify-glass-panel-surfaces.md
Brief: .convoys/unify-glass-panel-surfaces/brief-2-auth-form-cards.md
Architect plan: PR #119 (merged)

Made with Cursor

## Summary Brief 2 of `unify-glass-panel-surfaces`. Migrates the login + signup form-card containers from handrolled `rgba(--bg-secondary-rgb, 0.85)` + `backdrop-blur-sm` Tailwind glass imitation to the canonical `.glass-panel-strong rounded-2xl p-8` className. These are the first surfaces a new user sees; aligning them with the rest of the app's surface vocabulary means corner catch-lights, system blur tier, and the gradient border — not a handrolled approximation. ## Files changed - `pages/login.js` — form-card `<div>` className/style swap. - `pages/signup.js` — same swap on the symmetric form-card `<div>`. Net diff: **+2 / -14**. Pure className → className migration. ## Diff (representative) ```diff - <div - className="p-8 rounded-2xl shadow-2xl backdrop-blur-sm border border-opacity-20" - style={{ - backgroundColor: 'rgba(var(--bg-secondary-rgb), 0.85)', - borderColor: 'var(--border)', - }} - > + <div className="glass-panel-strong rounded-2xl p-8"> ``` ## Acceptance criteria - [x] `pages/login.js` form-card `<div>` uses `className="glass-panel-strong rounded-2xl p-8"` and no inline `backgroundColor`/`borderColor` style. - [x] `pages/signup.js` form-card `<div>` uses `className="glass-panel-strong rounded-2xl p-8"` and no inline `backgroundColor`/`borderColor` style. - [x] All form fields, labels, buttons, error banners, footer links unchanged (children are byte-identical). - [x] No edits to other files. No token additions in styles/globals.css. No new components. - [x] `npm run lint` passes (one pre-existing unrelated warning in `components/CollectionsPageView.js`). ## Test plan - [ ] Visit `/login` in light + dark mode; verify the form card renders with corner catch-lights and theme-correct background. - [ ] Visit `/signup` in light + dark mode; same verification. - [ ] Submit invalid credentials; verify the error banner still renders properly inside the new container. - [ ] Verify the existing `tests/smoke/auth.spec.js` continues to pass (no edits required). ## Related - Convoy: `.convoys/unify-glass-panel-surfaces.md` - Brief: `.convoys/unify-glass-panel-surfaces/brief-2-auth-form-cards.md` - Architect plan: PR #119 (merged) Made with [Cursor](https://cursor.com)

vercel[bot] commented

2026-06-04 15:12:37 -04:00

(Migrated from github.com)

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tcg-vault	Ready	Preview, Comment	Jun 4, 2026 7:12pm

[vc]: #2O4KUTmKt5kIQYaCf01q2U8HLjQWpWiFwvRYtBNgsUY=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJ0Y2ctdmF1bHQtZ2l0LWJyaWVmLTItYXV0aC1mLWJhMjk3Yi1yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMudmVyY2VsLmFwcCJ9LCJpbnNwZWN0b3JVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzL3RjZy12YXVsdC9Ec05yVGJjcHluTXZCQTVSeTM2ZnRzUVEzTWJuIiwicHJldmlld1VybCI6InRjZy12YXVsdC1naXQtYnJpZWYtMi1hdXRoLWYtYmEyOTdiLXJhbmRhbGwtc3RpbGx3ZWxscy1wcm9qZWN0cy52ZXJjZWwuYXBwIiwibmV4dENvbW1pdFN0YXR1cyI6IkRFUExPWUVEIn1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj0xMjEifQ== The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/DsNrTbcpynMvBA5Ry36ftsQQ3Mbn) | [Preview](https://tcg-vault-git-brief-2-auth-f-ba297b-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-brief-2-auth-f-ba297b-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | Jun 4, 2026 7:12pm | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=121" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>

github-actions[bot] commented

2026-06-04 15:12:46 -04:00

(Migrated from github.com)

Pipeline Health

Build + CI gates

Gate	Status
Vercel build (Preview)	✅ pass
CI: Lint	✅ pass
CI: Schema map fresh	❌ skipped
Preview smoke	✅ pass
Visual diff	✅ pass

Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build).

Role reports

Role	Status
Reviewer report	⏳ pending
A11y audit	⏳ pending
Design system audit	⏳ pending

See individual comments above for details. This rollup updates automatically.

## Pipeline Health ### Build + CI gates | Gate | Status | | --- | --- | | Vercel build (Preview) | ✅ pass | | CI: Lint | ✅ pass | | CI: Schema map fresh | ❌ skipped | | Preview smoke | ✅ pass | | Visual diff | ✅ pass | _Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build)._ ### Role reports | Role | Status | | --- | --- | | Reviewer report | ⏳ pending | | A11y audit | ⏳ pending | | Design system audit | ⏳ pending | See individual comments above for details. This rollup updates automatically.

github-actions[bot] commented

2026-06-04 15:13:52 -04:00

(Migrated from github.com)

Visual Diff

Screenshots and diffs uploaded as artifacts: view run

If intentional changes: update snapshots locally with npx playwright test --project=visual --update-snapshots and commit.

## Visual Diff Screenshots and diffs uploaded as artifacts: [view run](https://github.com/varutasu/tcg-vault/actions/runs/26973731415) If intentional changes: update snapshots locally with `npx playwright test --project=visual --update-snapshots` and commit.