Vocabulary cleanup follow-up #55

Merged

varutasu merged 1 commit from chore/vocabulary-cleanup-followup into main

2026-05-29 11:01:03 -04:00

varutasu commented

2026-05-29 10:57:50 -04:00

(Migrated from github.com)

Summary

Bug fix: Dashboard h1 was incorrectly set to "Lists" — restored to My Collection (the nav section home at /dashboard).
Sweep remaining user-facing copy on login, signup, homepage marketing, cards public view, my-cards, and scanner error strings.
Update system-list seed description for new signups via VOCAB.SYSTEM_COLLECTION_SEED_DESCRIPTION; DRY DB name through SYSTEM_COLLECTION_DB_NAME in register.
Add test/lib/collection-vocabulary.test.js (52/52 vitest).
Close .convoys/rename-collections-vocabulary.md (PR #54).

Not in this PR (intentionally deferred)

Existing users' system-list descriptions in DB still say "mark as owned" until a data migration.
API error messages under pages/api/ (out of CI grep scope).
Component/file renames (CollectionSelectionModal, etc.) — separate refactor.
Admin UI — out of original convoy scope.

Test plan

npm run test:run — 52/52 green
Forbidden-string grep clean in pages/components

Made with Cursor

## Summary - **Bug fix:** Dashboard h1 was incorrectly set to "Lists" — restored to **My Collection** (the nav section home at `/dashboard`). - Sweep remaining user-facing copy on login, signup, homepage marketing, cards public view, my-cards, and scanner error strings. - Update system-list seed description for new signups via `VOCAB.SYSTEM_COLLECTION_SEED_DESCRIPTION`; DRY DB name through `SYSTEM_COLLECTION_DB_NAME` in register. - Add `test/lib/collection-vocabulary.test.js` (52/52 vitest). - Close `.convoys/rename-collections-vocabulary.md` (PR #54). ## Not in this PR (intentionally deferred) - **Existing users' system-list descriptions** in DB still say "mark as owned" until a data migration. - **API error messages** under `pages/api/` (out of CI grep scope). - **Component/file renames** (`CollectionSelectionModal`, etc.) — separate refactor. - **Admin UI** — out of original convoy scope. ## Test plan - [x] `npm run test:run` — 52/52 green - [x] Forbidden-string grep clean in pages/components Made with [Cursor](https://cursor.com)

vercel[bot] commented

2026-05-29 10:57:52 -04:00

(Migrated from github.com)

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tcg-vault	Ready	Preview, Comment	May 29, 2026 2:58pm

[vc]: #7LoBHQBY6R74PdRSt7v1UPanN4XkigRxuihpvXe4YvU=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMvdGNnLXZhdWx0L0hzZDZndkdSeTI2SDlIeEZQRzFlR0FkVlhhZDkiLCJwcmV2aWV3VXJsIjoidGNnLXZhdWx0LWdpdC1jaG9yZS12b2NhYnVsYS00NWMyMTQtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoidGNnLXZhdWx0LWdpdC1jaG9yZS12b2NhYnVsYS00NWMyMTQtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAifSwicm9vdERpcmVjdG9yeSI6bnVsbH1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj01NSJ9 The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/Hsd6gvGRy26H9HxFPG1eGAdVXad9) | [Preview](https://tcg-vault-git-chore-vocabula-45c214-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-chore-vocabula-45c214-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | May 29, 2026 2:58pm | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=55" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>

github-actions[bot] commented

2026-05-29 10:58:06 -04:00

(Migrated from github.com)

Pipeline Health

Build + CI gates

Gate	Status
Vercel build (Preview)	✅ pass
CI: Lint	✅ pass
CI: Schema map fresh	❌ skipped
Preview smoke	✅ pass
Visual diff	✅ pass

Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build).

Role reports

Role	Status
Reviewer report	⏳ pending
A11y audit	⏳ pending
Design system audit	⏳ pending

See individual comments above for details. This rollup updates automatically.

## Pipeline Health ### Build + CI gates | Gate | Status | | --- | --- | | Vercel build (Preview) | ✅ pass | | CI: Lint | ✅ pass | | CI: Schema map fresh | ❌ skipped | | Preview smoke | ✅ pass | | Visual diff | ✅ pass | _Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build)._ ### Role reports | Role | Status | | --- | --- | | Reviewer report | ⏳ pending | | A11y audit | ⏳ pending | | Design system audit | ⏳ pending | See individual comments above for details. This rollup updates automatically.

github-actions[bot] commented

2026-05-29 10:59:14 -04:00

(Migrated from github.com)

Visual Diff

Screenshots and diffs uploaded as artifacts: view run

If intentional changes: update snapshots locally with npx playwright test --project=visual --update-snapshots and commit.

## Visual Diff Screenshots and diffs uploaded as artifacts: [view run](https://github.com/varutasu/tcg-vault/actions/runs/26644603537) If intentional changes: update snapshots locally with `npx playwright test --project=visual --update-snapshots` and commit.