deckhearth/pages/api/collections.js
Randall Stillwell f408e151c8 🔒 CRITICAL SECURITY FIX: Implement Proper User Data Isolation
🚨 Fixed Major Data Leakage Issues:
- Replaced hardcoded user_id = 1 with proper JWT authentication
- Fixed collections API to filter by authenticated user
- Fixed card ownership to use user_cards table (not global cards table)
- Fixed decks API to return only user-owned decks
- Fixed card collections/decks APIs to respect user permissions
- Fixed favorites API to use user_favorites table

🛡️ Authentication & Authorization:
- All endpoints now require valid JWT tokens
- Proper user isolation across all data operations
- Collection permissions properly enforced
- User-specific data queries implemented

🔧 Database Schema Fixes:
- Card ownership now uses user_cards table
- Favorites use user_favorites table
- Decks filtered by user_id
- Collections respect ownership and permissions

⚠️ Development Note:
- Added warning for fallback authentication in dev mode
- Should be removed in production deployment

 Data Privacy Secured:
- Users can only see their own collections, decks, and owned cards
- Public collections visible to all (as intended)
- Shared collections respect permission levels
- No cross-user data leakage
2025-07-26 00:29:51 -05:00

110 lines
No EOL
3.8 KiB
JavaScript

import { sql } from '@vercel/postgres';
import { getUserFromRequest, logCollectionActivity } from '../../lib/permission-middleware';
export default async function handler(req, res) {
// Set CORS headers
res.setHeader('Access-Control-Allow-Origin', '*');
res.setHeader('Access-Control-Allow-Methods', 'GET, POST, PUT, DELETE, OPTIONS');
res.setHeader('Access-Control-Allow-Headers', 'Content-Type, Authorization');
// Handle preflight requests
if (req.method === 'OPTIONS') {
res.status(200).end();
return;
}
if (req.method === 'GET') {
try {
// Get authenticated user
const user = await getUserFromRequest(req);
if (!user) {
return res.status(401).json({ error: 'Authentication required' });
}
const currentUserId = user.userId;
// Get collections based on ownership, collaboration, or public visibility
const result = await sql`
SELECT DISTINCT
c.*,
u.email as creator_email,
COUNT(cc.card_id) as card_count,
COALESCE(SUM(cards.market_price * cc.quantity), 0) as total_value,
cp.role as user_role,
CASE
WHEN c.user_id = ${currentUserId} THEN 'owner'
WHEN cp.role IS NOT NULL THEN cp.role
ELSE NULL
END as effective_role
FROM collections c
LEFT JOIN users u ON c.user_id = u.id
LEFT JOIN collection_cards cc ON c.id = cc.collection_id
LEFT JOIN cards ON cc.card_id = cards.id
LEFT JOIN collection_permissions cp ON c.id = cp.collection_id AND cp.user_id = ${currentUserId} AND cp.status = 'active'
WHERE
c.user_id = ${currentUserId} OR
cp.id IS NOT NULL OR
(c.is_public = true)
GROUP BY c.id, u.email, cp.role
ORDER BY c.updated_at DESC
`;
const collections = result.rows.map(collection => ({
id: collection.id,
name: collection.name,
description: collection.description,
tcg: collection.tcg || 'MTG',
cardCount: parseInt(collection.card_count) || 0,
value: parseFloat(collection.total_value) || 0,
lastViewed: collection.updated_at,
createdAt: collection.created_at,
isPublic: collection.is_public || false,
tags: collection.tags ? collection.tags.split(',') : [],
creator: collection.creator_email,
userRole: collection.effective_role
}));
res.status(200).json(collections);
} catch (error) {
console.error('Error fetching collections:', error);
res.status(500).json({ error: 'Internal server error' });
}
} else if (req.method === 'POST') {
try {
// Get authenticated user
const user = await getUserFromRequest(req);
if (!user) {
return res.status(401).json({ error: 'Authentication required' });
}
const { name, description, tcg = 'MTG', isPublic = false, image = '', tags = [] } = req.body;
if (!name || !description) {
return res.status(400).json({ error: 'Name and description are required' });
}
const userId = user.userId;
const result = await sql`
INSERT INTO collections (name, description, tcg, is_public, image, tags, user_id)
VALUES (${name}, ${description}, ${tcg}, ${isPublic}, ${image}, ${tags.join(',')}, ${userId})
RETURNING *
`;
// Create owner permission record
await sql`
INSERT INTO collection_permissions (collection_id, user_id, role, status)
VALUES (${result.rows[0].id}, ${userId}, 'owner', 'active')
`;
res.status(201).json(result.rows[0]);
} catch (error) {
console.error('Error creating collection:', error);
res.status(500).json({ error: 'Internal server error' });
}
} else {
res.status(405).json({ error: 'Method not allowed' });
}
}