deckhearth/pages/api/favorites.js
Randall Stillwell a84373642e fix(security): drop wildcard CORS + redundant OPTIONS from 24 API routes (P0 #5)
Closes P0 #5 (CORS) from PARTIAL → RESOLVED. fix-auth-bypass
Brief 4 (commit 297afca) cleaned login + register; this brief
sweeps the remaining 24 pages/api/** handlers that carried the
identical scaffolded wildcard-CORS + redundant-OPTIONS pattern,
plus adds a blocking forbidden-cors-headers CI job to lock in
the cleanup against future regression.

Per architect Decision 1 — Option B (sweep all 24 in one PR)
chosen over Option A (narrow verify.js-only + queue separate
sweep). Pattern-drift audit (14 of 24 files spot-checked across
parent + architect) found zero drift; mechanical safety
confirmed.

Per Decision 2 — OPTIONS handler deleted entirely (matches
Brief 4 precedent). Same-origin Vercel deployment doesn't
preflight; method check at top of handler returns 405 if any
client ever sends OPTIONS again.

Per Decision 3 — verify.js's overly-permissive Allow-Methods:
'GET, POST, PUT, DELETE, OPTIONS' is moot (deleted under D2);
the handler's existing `if (req.method !== 'GET') return 405`
guard at line 17 (now line ~5) is the remaining gate.

Per Decision 4 — no new per-route tests this convoy. None of
the 24 routes have vitest coverage today; adding handler-level
tests is the queued fill-vitest-handler-coverage convoy.

Per Decision 5 — new `forbidden-cors-headers` CI job added,
modeled verbatim on `forbidden-endpoints`. Blocking (no
`|| true`, no `continue-on-error`). Greps pages/api/ for any
`Access-Control-Allow-(Origin|Methods|Headers)` reappearance
and exits 1 on hit.

Verification:
  - npm run lint: 128 problems (baseline match)
  - npm run test:run: 21/21 vitest pass (no regression)
  - git grep -nE "Access-Control-Allow-..." -- 'pages/api/**':
    zero matches
  - git grep -nE "OPTIONS" -- 'pages/api/**': zero matches
    (post-sweep)
  - new forbidden-cors-headers grep exits 0 against swept tree

No code paths in lib/**, components/**, scripts/**, or test/**
touched. No package.json / lockfile churn. No workflow YAML
beyond the single ci.yml job addition. No AGENTS.md edits
(doc-writer pass at convoy close).

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-24 20:24:47 -05:00

126 lines
No EOL
4 KiB
JavaScript

import { sql } from '@vercel/postgres';
import jwt from 'jsonwebtoken';
import { JWT_SECRET } from '../../lib/auth-secret.js';
export default async function handler(req, res) {
// Verify authentication
const authHeader = req.headers.authorization;
if (!authHeader || !authHeader.startsWith('Bearer ')) {
return res.status(401).json({ error: 'Authentication required' });
}
const token = authHeader.substring(7);
let user;
try {
user = jwt.verify(token, JWT_SECRET);
} catch (error) {
return res.status(401).json({ error: 'Invalid token' });
}
try {
if (req.method === 'GET') {
// Get user's favorites
const { type } = req.query; // Optional filter by type
let result;
if (type) {
result = await sql`
SELECT uf.*,
CASE
WHEN uf.item_type = 'collection' THEN c.name
WHEN uf.item_type = 'card' THEN cards.name
WHEN uf.item_type = 'deck' THEN d.name
END as item_name
FROM user_favorites uf
LEFT JOIN collections c ON uf.item_type = 'collection' AND uf.item_id = c.id
LEFT JOIN cards ON uf.item_type = 'card' AND uf.item_id = cards.id
LEFT JOIN decks d ON uf.item_type = 'deck' AND uf.item_id = d.id
WHERE uf.user_id = ${user.userId} AND uf.item_type = ${type}
ORDER BY uf.created_at DESC
`;
} else {
result = await sql`
SELECT uf.*,
CASE
WHEN uf.item_type = 'collection' THEN c.name
WHEN uf.item_type = 'card' THEN cards.name
WHEN uf.item_type = 'deck' THEN d.name
END as item_name
FROM user_favorites uf
LEFT JOIN collections c ON uf.item_type = 'collection' AND uf.item_id = c.id
LEFT JOIN cards ON uf.item_type = 'card' AND uf.item_id = cards.id
LEFT JOIN decks d ON uf.item_type = 'deck' AND uf.item_id = d.id
WHERE uf.user_id = ${user.userId}
ORDER BY uf.created_at DESC
`;
}
res.status(200).json({
favorites: result.rows
});
} else if (req.method === 'POST') {
// Add favorite
const { itemType, itemId } = req.body;
if (!itemType || !itemId) {
return res.status(400).json({ error: 'itemType and itemId are required' });
}
if (!['card', 'collection', 'deck'].includes(itemType)) {
return res.status(400).json({ error: 'Invalid itemType. Must be card, collection, or deck' });
}
// Check if already favorited
const existing = await sql`
SELECT id FROM user_favorites
WHERE user_id = ${user.userId} AND item_type = ${itemType} AND item_id = ${itemId}
`;
if (existing.rows.length > 0) {
return res.status(409).json({ error: 'Item already favorited' });
}
// Add favorite
const result = await sql`
INSERT INTO user_favorites (user_id, item_type, item_id)
VALUES (${user.userId}, ${itemType}, ${itemId})
RETURNING *
`;
res.status(201).json({
favorite: result.rows[0]
});
} else if (req.method === 'DELETE') {
// Remove favorite
const { itemType, itemId } = req.body;
if (!itemType || !itemId) {
return res.status(400).json({ error: 'itemType and itemId are required' });
}
const result = await sql`
DELETE FROM user_favorites
WHERE user_id = ${user.userId} AND item_type = ${itemType} AND item_id = ${itemId}
RETURNING *
`;
if (result.rows.length === 0) {
return res.status(404).json({ error: 'Favorite not found' });
}
res.status(200).json({
message: 'Favorite removed',
favorite: result.rows[0]
});
} else {
res.status(405).json({ error: 'Method not allowed' });
}
} catch (error) {
console.error('Favorites API error:', error);
res.status(500).json({ error: 'Internal server error' });
}
}