a84373642e
Closes P0 #5 (CORS) from PARTIAL → RESOLVED. fix-auth-bypass
Brief 4 (commit 297afca) cleaned login + register; this brief
sweeps the remaining 24 pages/api/** handlers that carried the
identical scaffolded wildcard-CORS + redundant-OPTIONS pattern,
plus adds a blocking forbidden-cors-headers CI job to lock in
the cleanup against future regression.
Per architect Decision 1 — Option B (sweep all 24 in one PR)
chosen over Option A (narrow verify.js-only + queue separate
sweep). Pattern-drift audit (14 of 24 files spot-checked across
parent + architect) found zero drift; mechanical safety
confirmed.
Per Decision 2 — OPTIONS handler deleted entirely (matches
Brief 4 precedent). Same-origin Vercel deployment doesn't
preflight; method check at top of handler returns 405 if any
client ever sends OPTIONS again.
Per Decision 3 — verify.js's overly-permissive Allow-Methods:
'GET, POST, PUT, DELETE, OPTIONS' is moot (deleted under D2);
the handler's existing `if (req.method !== 'GET') return 405`
guard at line 17 (now line ~5) is the remaining gate.
Per Decision 4 — no new per-route tests this convoy. None of
the 24 routes have vitest coverage today; adding handler-level
tests is the queued fill-vitest-handler-coverage convoy.
Per Decision 5 — new `forbidden-cors-headers` CI job added,
modeled verbatim on `forbidden-endpoints`. Blocking (no
`|| true`, no `continue-on-error`). Greps pages/api/ for any
`Access-Control-Allow-(Origin|Methods|Headers)` reappearance
and exits 1 on hit.
Verification:
- npm run lint: 128 problems (baseline match)
- npm run test:run: 21/21 vitest pass (no regression)
- git grep -nE "Access-Control-Allow-..." -- 'pages/api/**':
zero matches
- git grep -nE "OPTIONS" -- 'pages/api/**': zero matches
(post-sweep)
- new forbidden-cors-headers grep exits 0 against swept tree
No code paths in lib/**, components/**, scripts/**, or test/**
touched. No package.json / lockfile churn. No workflow YAML
beyond the single ci.yml job addition. No AGENTS.md edits
(doc-writer pass at convoy close).
Co-authored-by: Cursor <cursoragent@cursor.com>
79 lines
No EOL
2.4 KiB
JavaScript
79 lines
No EOL
2.4 KiB
JavaScript
import { sql } from '@vercel/postgres';
|
|
import { getUserFromRequest } from '../../../../lib/permission-middleware';
|
|
import { isValidSlug } from '../../../../lib/slug-utils';
|
|
|
|
export default async function handler(req, res) {
|
|
if (req.method !== 'GET') {
|
|
return res.status(405).json({ error: 'Method not allowed' });
|
|
}
|
|
|
|
try {
|
|
// Get authenticated user
|
|
const user = await getUserFromRequest(req);
|
|
if (!user) {
|
|
return res.status(401).json({ error: 'Authentication required' });
|
|
}
|
|
|
|
const { identifier } = req.query;
|
|
|
|
if (!identifier) {
|
|
return res.status(400).json({ error: 'Collection identifier is required' });
|
|
}
|
|
|
|
// Determine if identifier is a slug or numeric ID
|
|
const isSlug = isValidSlug(identifier) || isNaN(parseInt(identifier));
|
|
|
|
// Verify user has access to this collection
|
|
let collectionResult;
|
|
if (isSlug) {
|
|
collectionResult = await sql`
|
|
SELECT c.*, cp.role as user_role
|
|
FROM collections c
|
|
LEFT JOIN collection_permissions cp ON c.id = cp.collection_id AND cp.user_id = ${user.userId} AND cp.status = 'active'
|
|
WHERE c.slug = ${identifier}
|
|
AND (
|
|
c.user_id = ${user.userId} OR
|
|
cp.id IS NOT NULL OR
|
|
c.is_public = true
|
|
)
|
|
`;
|
|
} else {
|
|
const numericId = parseInt(identifier);
|
|
collectionResult = await sql`
|
|
SELECT c.*, cp.role as user_role
|
|
FROM collections c
|
|
LEFT JOIN collection_permissions cp ON c.id = cp.collection_id AND cp.user_id = ${user.userId} AND cp.status = 'active'
|
|
WHERE c.id = ${numericId}
|
|
AND (
|
|
c.user_id = ${user.userId} OR
|
|
cp.id IS NOT NULL OR
|
|
c.is_public = true
|
|
)
|
|
`;
|
|
}
|
|
|
|
if (collectionResult.length === 0) {
|
|
return res.status(404).json({ error: 'Collection not found or access denied' });
|
|
}
|
|
|
|
const collection = collectionResult[0];
|
|
|
|
// Get collection activity (this would typically come from an activity log table)
|
|
// For now, we'll return a simple mock response
|
|
const activities = [
|
|
{
|
|
id: 1,
|
|
type: 'card_added',
|
|
description: 'Added Lightning Bolt to collection',
|
|
timestamp: new Date().toISOString(),
|
|
user: user.email
|
|
}
|
|
];
|
|
|
|
res.status(200).json({ activities });
|
|
|
|
} catch (error) {
|
|
console.error('Collection activity API error:', error);
|
|
res.status(500).json({ error: 'Internal server error' });
|
|
}
|
|
}
|