deckhearth/pages/api/cards/[id]/ownership.js
Randall Stillwell a84373642e fix(security): drop wildcard CORS + redundant OPTIONS from 24 API routes (P0 #5)
Closes P0 #5 (CORS) from PARTIAL → RESOLVED. fix-auth-bypass
Brief 4 (commit 297afca) cleaned login + register; this brief
sweeps the remaining 24 pages/api/** handlers that carried the
identical scaffolded wildcard-CORS + redundant-OPTIONS pattern,
plus adds a blocking forbidden-cors-headers CI job to lock in
the cleanup against future regression.

Per architect Decision 1 — Option B (sweep all 24 in one PR)
chosen over Option A (narrow verify.js-only + queue separate
sweep). Pattern-drift audit (14 of 24 files spot-checked across
parent + architect) found zero drift; mechanical safety
confirmed.

Per Decision 2 — OPTIONS handler deleted entirely (matches
Brief 4 precedent). Same-origin Vercel deployment doesn't
preflight; method check at top of handler returns 405 if any
client ever sends OPTIONS again.

Per Decision 3 — verify.js's overly-permissive Allow-Methods:
'GET, POST, PUT, DELETE, OPTIONS' is moot (deleted under D2);
the handler's existing `if (req.method !== 'GET') return 405`
guard at line 17 (now line ~5) is the remaining gate.

Per Decision 4 — no new per-route tests this convoy. None of
the 24 routes have vitest coverage today; adding handler-level
tests is the queued fill-vitest-handler-coverage convoy.

Per Decision 5 — new `forbidden-cors-headers` CI job added,
modeled verbatim on `forbidden-endpoints`. Blocking (no
`|| true`, no `continue-on-error`). Greps pages/api/ for any
`Access-Control-Allow-(Origin|Methods|Headers)` reappearance
and exits 1 on hit.

Verification:
  - npm run lint: 128 problems (baseline match)
  - npm run test:run: 21/21 vitest pass (no regression)
  - git grep -nE "Access-Control-Allow-..." -- 'pages/api/**':
    zero matches
  - git grep -nE "OPTIONS" -- 'pages/api/**': zero matches
    (post-sweep)
  - new forbidden-cors-headers grep exits 0 against swept tree

No code paths in lib/**, components/**, scripts/**, or test/**
touched. No package.json / lockfile churn. No workflow YAML
beyond the single ci.yml job addition. No AGENTS.md edits
(doc-writer pass at convoy close).

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-24 20:24:47 -05:00

106 lines
No EOL
3.3 KiB
JavaScript

import { sql } from '@vercel/postgres';
import { getUserFromRequest } from '../../../../lib/permission-middleware';
export default async function handler(req, res) {
if (req.method !== 'POST') {
return res.status(405).json({ error: 'Method not allowed' });
}
try {
// Get authenticated user
const user = await getUserFromRequest(req);
if (!user) {
return res.status(401).json({ error: 'Authentication required' });
}
const { id } = req.query;
const { quantity } = req.body;
if (!id || quantity === undefined) {
return res.status(400).json({ error: 'Card ID and quantity are required' });
}
const cardId = parseInt(id);
const cardQuantity = parseInt(quantity);
if (isNaN(cardId) || isNaN(cardQuantity) || cardQuantity < 0) {
return res.status(400).json({ error: 'Invalid card ID or quantity' });
}
// Verify the card exists
const cardCheck = await sql`SELECT id, name FROM cards WHERE id = ${cardId}`;
if (cardCheck.rows.length === 0) {
return res.status(404).json({ error: 'Card not found' });
}
const card = cardCheck.rows[0];
// Find the user's "All My Cards" collection
const allMyCardsCollection = await sql`
SELECT id FROM collections
WHERE user_id = ${user.userId}
AND name = 'All My Cards'
AND is_system_collection = true
`;
if (allMyCardsCollection.rows.length === 0) {
return res.status(500).json({ error: 'All My Cards collection not found' });
}
const collectionId = allMyCardsCollection.rows[0].id;
if (cardQuantity > 0) {
// Insert or update user's card ownership
const result = await sql`
INSERT INTO user_cards (user_id, card_id, quantity, created_at, updated_at)
VALUES (${user.userId}, ${cardId}, ${cardQuantity}, CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)
ON CONFLICT (user_id, card_id)
DO UPDATE SET
quantity = ${cardQuantity},
updated_at = CURRENT_TIMESTAMP
RETURNING *
`;
// Sync with "All My Cards" collection
const collectionCardResult = await sql`
INSERT INTO collection_cards (collection_id, card_id, quantity, created_at)
VALUES (${collectionId}, ${cardId}, ${cardQuantity}, CURRENT_TIMESTAMP)
ON CONFLICT (collection_id, card_id)
DO UPDATE SET
quantity = ${cardQuantity}
RETURNING *
`;
res.status(200).json({
success: true,
message: 'Card ownership updated and synced to All My Cards collection',
card: {
id: card.id,
name: card.name,
quantity: result.rows[0].quantity
}
});
} else {
// Remove card ownership
await sql`DELETE FROM user_cards WHERE user_id = ${user.userId} AND card_id = ${cardId}`;
// Remove from "All My Cards" collection
await sql`DELETE FROM collection_cards WHERE collection_id = ${collectionId} AND card_id = ${cardId}`;
res.status(200).json({
success: true,
message: 'Card ownership removed and synced from All My Cards collection',
card: {
id: card.id,
name: card.name,
quantity: 0
}
});
}
} catch (error) {
console.error('Error handling ownership:', error);
res.status(500).json({ error: 'Internal server error' });
}
}