f408e151c8
🚨 Fixed Major Data Leakage Issues: - Replaced hardcoded user_id = 1 with proper JWT authentication - Fixed collections API to filter by authenticated user - Fixed card ownership to use user_cards table (not global cards table) - Fixed decks API to return only user-owned decks - Fixed card collections/decks APIs to respect user permissions - Fixed favorites API to use user_favorites table 🛡️ Authentication & Authorization: - All endpoints now require valid JWT tokens - Proper user isolation across all data operations - Collection permissions properly enforced - User-specific data queries implemented 🔧 Database Schema Fixes: - Card ownership now uses user_cards table - Favorites use user_favorites table - Decks filtered by user_id - Collections respect ownership and permissions ⚠️ Development Note: - Added warning for fallback authentication in dev mode - Should be removed in production deployment ✅ Data Privacy Secured: - Users can only see their own collections, decks, and owned cards - Public collections visible to all (as intended) - Shared collections respect permission levels - No cross-user data leakage
57 lines
No EOL
1.5 KiB
JavaScript
57 lines
No EOL
1.5 KiB
JavaScript
import { sql } from '@vercel/postgres';
|
|
import { getUserFromRequest } from '../../../../lib/permission-middleware';
|
|
|
|
export default async function handler(req, res) {
|
|
if (req.method !== 'POST') {
|
|
return res.status(405).json({ error: 'Method not allowed' });
|
|
}
|
|
|
|
const { id } = req.query;
|
|
const { favorited } = req.body;
|
|
|
|
try {
|
|
// Get authenticated user
|
|
const user = await getUserFromRequest(req);
|
|
if (!user) {
|
|
return res.status(401).json({ error: 'Authentication required' });
|
|
}
|
|
|
|
// Check if card exists
|
|
const cardCheck = await sql`
|
|
SELECT id, name FROM cards WHERE id = ${id}
|
|
`;
|
|
|
|
if (cardCheck.rows.length === 0) {
|
|
return res.status(404).json({ error: 'Card not found' });
|
|
}
|
|
|
|
const card = cardCheck.rows[0];
|
|
|
|
if (favorited) {
|
|
// Add to user favorites
|
|
await sql`
|
|
INSERT INTO user_favorites (user_id, item_type, item_id)
|
|
VALUES (${user.userId}, 'card', ${id})
|
|
ON CONFLICT (user_id, item_type, item_id) DO NOTHING
|
|
`;
|
|
} else {
|
|
// Remove from user favorites
|
|
await sql`
|
|
DELETE FROM user_favorites
|
|
WHERE user_id = ${user.userId} AND item_type = 'card' AND item_id = ${id}
|
|
`;
|
|
}
|
|
|
|
res.status(200).json({
|
|
success: true,
|
|
card: {
|
|
id: card.id,
|
|
name: card.name,
|
|
favorited: favorited
|
|
}
|
|
});
|
|
} catch (error) {
|
|
console.error('Error updating favorite status:', error);
|
|
res.status(500).json({ error: 'Failed to update favorite status' });
|
|
}
|
|
}
|