f408e151c8
🚨 Fixed Major Data Leakage Issues: - Replaced hardcoded user_id = 1 with proper JWT authentication - Fixed collections API to filter by authenticated user - Fixed card ownership to use user_cards table (not global cards table) - Fixed decks API to return only user-owned decks - Fixed card collections/decks APIs to respect user permissions - Fixed favorites API to use user_favorites table 🛡️ Authentication & Authorization: - All endpoints now require valid JWT tokens - Proper user isolation across all data operations - Collection permissions properly enforced - User-specific data queries implemented 🔧 Database Schema Fixes: - Card ownership now uses user_cards table - Favorites use user_favorites table - Decks filtered by user_id - Collections respect ownership and permissions ⚠️ Development Note: - Added warning for fallback authentication in dev mode - Should be removed in production deployment ✅ Data Privacy Secured: - Users can only see their own collections, decks, and owned cards - Public collections visible to all (as intended) - Shared collections respect permission levels - No cross-user data leakage
74 lines
No EOL
2.1 KiB
JavaScript
74 lines
No EOL
2.1 KiB
JavaScript
import { sql } from '@vercel/postgres';
|
|
import { getUserFromRequest } from '../../../../lib/permission-middleware';
|
|
|
|
export default async function handler(req, res) {
|
|
const { id } = req.query;
|
|
|
|
if (req.method === 'GET') {
|
|
try {
|
|
// Get authenticated user
|
|
const user = await getUserFromRequest(req);
|
|
if (!user) {
|
|
return res.status(401).json({ error: 'Authentication required' });
|
|
}
|
|
|
|
// Get decks that contain this card and belong to the user
|
|
const result = await sql`
|
|
SELECT DISTINCT
|
|
d.id,
|
|
d.name,
|
|
d.description,
|
|
dc.quantity
|
|
FROM decks d
|
|
JOIN deck_cards dc ON d.id = dc.deck_id
|
|
WHERE dc.card_id = ${id}
|
|
AND d.user_id = ${user.userId}
|
|
ORDER BY d.name
|
|
`;
|
|
|
|
res.status(200).json(result.rows);
|
|
} catch (error) {
|
|
console.error('Error fetching card decks:', error);
|
|
res.status(500).json({ error: 'Failed to fetch card decks' });
|
|
}
|
|
} else if (req.method === 'POST') {
|
|
try {
|
|
// Get authenticated user
|
|
const user = await getUserFromRequest(req);
|
|
if (!user) {
|
|
return res.status(401).json({ error: 'Authentication required' });
|
|
}
|
|
|
|
const { deckId } = req.body;
|
|
|
|
// Check if user owns this deck
|
|
const deckCheck = await sql`
|
|
SELECT id, name
|
|
FROM decks
|
|
WHERE id = ${deckId} AND user_id = ${user.userId}
|
|
`;
|
|
|
|
if (deckCheck.rows.length === 0) {
|
|
return res.status(403).json({ error: 'Deck not found or access denied' });
|
|
}
|
|
|
|
// Add card to deck
|
|
await sql`
|
|
INSERT INTO deck_cards (deck_id, card_id, quantity)
|
|
VALUES (${deckId}, ${id}, 1)
|
|
ON CONFLICT (deck_id, card_id)
|
|
DO UPDATE SET quantity = deck_cards.quantity + 1
|
|
`;
|
|
|
|
res.status(200).json({
|
|
success: true,
|
|
message: 'Card added to deck'
|
|
});
|
|
} catch (error) {
|
|
console.error('Error adding card to deck:', error);
|
|
res.status(500).json({ error: 'Failed to add card to deck' });
|
|
}
|
|
} else {
|
|
res.status(405).json({ error: 'Method not allowed' });
|
|
}
|
|
}
|