rstillwell/deckhearth
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix(ci): plumb VERCEL_AUTOMATION_BYPASS_SECRET into preview-smoke + visual-diff #17

Merged
varutasu merged 4 commits from convoy/fix-vercel-deployment-protection-in-ci into main 2026-05-24 17:26:22 -04:00
Conversation 2 Commits 4 Files changed 4 +14 -4
2 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 365e9f02f7 - Show all commits

9
.github/workflows/preview-smoke.yml vendored
View file

@ -41,7 +41,10 @@ jobs:
- name: Decide - name: Decide
id: check id: check
run: | run: |
if echo "${{ github.event.pull_request.body }}" | grep -qE 'pipeline:.*skip.*\bsmoke\b'; then if [[ "${{ github.event.pull_request.head.repo.fork }}" == "true" ]]; then
echo "should_run=false" >> $GITHUB_OUTPUT
echo "::notice::Smoke skipped on fork PR (bypass secret unavailable to forks)"
elif echo "${{ github.event.pull_request.body }}" | grep -qE 'pipeline:.*skip.*\bsmoke\b'; then
echo "should_run=false" >> $GITHUB_OUTPUT echo "should_run=false" >> $GITHUB_OUTPUT
echo "::notice::Smoke skipped via pipeline directive" echo "::notice::Smoke skipped via pipeline directive"
else else
@ -62,7 +65,8 @@ jobs:
uses: patrickedqvist/wait-for-vercel-preview@v1.3.2 uses: patrickedqvist/wait-for-vercel-preview@v1.3.2
with: with:
token: ${{ secrets.GITHUB_TOKEN }} token: ${{ secrets.GITHUB_TOKEN }}
max_timeout: 600 max_timeout: 120
path: /?x-vercel-protection-bypass=${{ secrets.VERCEL_AUTOMATION_BYPASS_SECRET }}&x-vercel-set-bypass-cookie=true
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:
@ -78,6 +82,7 @@ jobs:
run: npx playwright test --project=smoke run: npx playwright test --project=smoke
env: env:
BASE_URL: ${{ steps.vercel.outputs.url }} BASE_URL: ${{ steps.vercel.outputs.url }}
VERCEL_AUTOMATION_BYPASS_SECRET: ${{ secrets.VERCEL_AUTOMATION_BYPASS_SECRET }}
- name: Upload Playwright report on failure - name: Upload Playwright report on failure
if: failure() if: failure()

9
.github/workflows/visual-diff.yml vendored
View file

@ -37,7 +37,10 @@ jobs:
steps: steps:
- id: check - id: check
run: | run: |
if echo "${{ github.event.pull_request.body }}" | grep -qE 'pipeline:.*skip.*\bvisual\b'; then if [[ "${{ github.event.pull_request.head.repo.fork }}" == "true" ]]; then
echo "should_run=false" >> $GITHUB_OUTPUT
echo "::notice::Visual diff skipped on fork PR (bypass secret unavailable to forks)"
elif echo "${{ github.event.pull_request.body }}" | grep -qE 'pipeline:.*skip.*\bvisual\b'; then
echo "should_run=false" >> $GITHUB_OUTPUT echo "should_run=false" >> $GITHUB_OUTPUT
echo "::notice::Visual diff skipped via pipeline directive" echo "::notice::Visual diff skipped via pipeline directive"
else else
@ -58,7 +61,8 @@ jobs:
uses: patrickedqvist/wait-for-vercel-preview@v1.3.2 uses: patrickedqvist/wait-for-vercel-preview@v1.3.2
with: with:
token: ${{ secrets.GITHUB_TOKEN }} token: ${{ secrets.GITHUB_TOKEN }}
max_timeout: 600 max_timeout: 120
path: /?x-vercel-protection-bypass=${{ secrets.VERCEL_AUTOMATION_BYPASS_SECRET }}&x-vercel-set-bypass-cookie=true
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:
@ -72,6 +76,7 @@ jobs:
run: npx playwright test --project=visual --update-snapshots=none run: npx playwright test --project=visual --update-snapshots=none
env: env:
BASE_URL: ${{ steps.vercel.outputs.url }} BASE_URL: ${{ steps.vercel.outputs.url }}
VERCEL_AUTOMATION_BYPASS_SECRET: ${{ secrets.VERCEL_AUTOMATION_BYPASS_SECRET }}
continue-on-error: true continue-on-error: true
- name: Upload screenshots + diffs - name: Upload screenshots + diffs