refactor(scanner): extract session and route API libs (page Brief 1) #74

Merged

varutasu merged 1 commit from refactor/scanner-page-split-brief-1 into main

2026-06-02 17:15:27 -04:00

varutasu commented

2026-06-02 17:07:36 -04:00

(Migrated from github.com)

Summary

Extract scanner session persistence + queue merge helpers to lib/scanner-session.js
Extract destination routing API calls to lib/scanner-route-api.js
Wire pages/scanner.js to the new libs (825 → 661 lines)
Bugfix: load collections/decks on mount — helpers existed but were never called, so destination pickers stayed empty
Remove unused ManaSymbols / ManaSymbolSettings imports and dead selectAllCards helpers

Test plan

npm run lint — 0 problems
npm run test:run — 80/80 pass (+6 new tests)
CI green
Manual: open /scanner — lists and decks populate in destination picker

Next (Brief 2)

useScannerQueue hook for queue/bulk/selection state
ScannerPageView presentational component

Made with Cursor

## Summary - Extract scanner session persistence + queue merge helpers to `lib/scanner-session.js` - Extract destination routing API calls to `lib/scanner-route-api.js` - Wire `pages/scanner.js` to the new libs (**825 → 661 lines**) - **Bugfix:** load collections/decks on mount — helpers existed but were never called, so destination pickers stayed empty - Remove unused `ManaSymbols` / `ManaSymbolSettings` imports and dead `selectAllCards` helpers ## Test plan - [x] `npm run lint` — 0 problems - [x] `npm run test:run` — 80/80 pass (+6 new tests) - [ ] CI green - [ ] Manual: open `/scanner` — lists and decks populate in destination picker ## Next (Brief 2) - `useScannerQueue` hook for queue/bulk/selection state - `ScannerPageView` presentational component Made with [Cursor](https://cursor.com)

vercel[bot] commented

2026-06-02 17:07:38 -04:00

(Migrated from github.com)

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tcg-vault	Ready	Preview, Comment	Jun 2, 2026 9:07pm

[vc]: #t68ACugWBBPAkUoYh9fnDEA5HmKbZhEOULmy5wV8ggs=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMvdGNnLXZhdWx0L0FaN2pFWVJHcjFaRkRLamg0cmdnMTFFR0JSUmkiLCJwcmV2aWV3VXJsIjoidGNnLXZhdWx0LWdpdC1yZWZhY3Rvci1zY2Fubi1jMzg2YjgtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoidGNnLXZhdWx0LWdpdC1yZWZhY3Rvci1zY2Fubi1jMzg2YjgtcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAifSwicm9vdERpcmVjdG9yeSI6bnVsbH1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj03NCJ9 The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/AZ7jEYRGr1ZFDKjh4rgg11EGBRRi) | [Preview](https://tcg-vault-git-refactor-scann-c386b8-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-refactor-scann-c386b8-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | Jun 2, 2026 9:07pm | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=74" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>

github-actions[bot] commented

2026-06-02 17:07:49 -04:00

(Migrated from github.com)

Pipeline Health

Build + CI gates

Gate	Status
Vercel build (Preview)	✅ pass
CI: Lint	✅ pass
CI: Schema map fresh	❌ skipped
Preview smoke	✅ pass
Visual diff	✅ pass

Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build).

Role reports

Role	Status
Reviewer report	⏳ pending
A11y audit	⏳ pending
Design system audit	⏳ pending

See individual comments above for details. This rollup updates automatically.

## Pipeline Health ### Build + CI gates | Gate | Status | | --- | --- | | Vercel build (Preview) | ✅ pass | | CI: Lint | ✅ pass | | CI: Schema map fresh | ❌ skipped | | Preview smoke | ✅ pass | | Visual diff | ✅ pass | _Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build)._ ### Role reports | Role | Status | | --- | --- | | Reviewer report | ⏳ pending | | A11y audit | ⏳ pending | | Design system audit | ⏳ pending | See individual comments above for details. This rollup updates automatically.

github-actions[bot] commented

2026-06-02 17:08:57 -04:00

(Migrated from github.com)

Visual Diff

Screenshots and diffs uploaded as artifacts: view run

If intentional changes: update snapshots locally with npx playwright test --project=visual --update-snapshots and commit.

## Visual Diff Screenshots and diffs uploaded as artifacts: [view run](https://github.com/varutasu/tcg-vault/actions/runs/26848113381) If intentional changes: update snapshots locally with `npx playwright test --project=visual --update-snapshots` and commit.