fix(lint): clear ESLint baseline in components/ #61

Merged

varutasu merged 1 commit from chore/fix-lint-components into main

2026-06-02 02:03:36 -04:00

varutasu commented

2026-06-02 01:45:39 -04:00

(Migrated from github.com)

Summary

Clears all 34 ESLint problems (20 errors, 14 warnings) in components/ so npx eslint components/ exits 0
Fixes React Compiler hook rules (purity, immutability, refs, set-state-in-effect) without changing scanner or UI behavior
Adds file-level @next/next/no-img-element disables matching the existing pages/ pattern for external card URLs

Test plan

npx eslint components/ → exit 0 (was 34 problems)
npm run test:run → 53/53 pass

Notes

Wave 2 slice F — components only; pages/, lib/, and CI untouched.

Made with Cursor

## Summary - Clears all 34 ESLint problems (20 errors, 14 warnings) in `components/` so `npx eslint components/` exits 0 - Fixes React Compiler hook rules (purity, immutability, refs, set-state-in-effect) without changing scanner or UI behavior - Adds file-level `@next/next/no-img-element` disables matching the existing `pages/` pattern for external card URLs ## Test plan - [x] `npx eslint components/` → exit 0 (was 34 problems) - [x] `npm run test:run` → 53/53 pass ## Notes Wave 2 slice F — components only; `pages/`, `lib/`, and CI untouched. Made with [Cursor](https://cursor.com)

vercel[bot] commented

2026-06-02 01:45:45 -04:00

(Migrated from github.com)

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tcg-vault	Ready	Preview, Comment	Jun 2, 2026 5:45am

[vc]: #VEyRXKGY2bqrpGQiAzkM4t1tzBh1S5xJnOKz8VFInOs=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ0Y2ctdmF1bHQiLCJwcm9qZWN0SWQiOiJwcmpfRjZXOEVvRkd3Y0g3aWVGcnRvRlNlOXdVVkFhNSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9yYW5kYWxsLXN0aWxsd2VsbHMtcHJvamVjdHMvdGNnLXZhdWx0LzhIbkVYQUh0NTlkRFRuTW9TVE5qYnh5b1FjWEgiLCJwcmV2aWV3VXJsIjoidGNnLXZhdWx0LWdpdC1jaG9yZS1maXgtbGludC1jYWM0OWItcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoidGNnLXZhdWx0LWdpdC1jaG9yZS1maXgtbGludC1jYWM0OWItcmFuZGFsbC1zdGlsbHdlbGxzLXByb2plY3RzLnZlcmNlbC5hcHAifSwicm9vdERpcmVjdG9yeSI6bnVsbH1dLCJyZXF1ZXN0UmV2aWV3VXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3ZlcmNlbC1hZ2VudC9yZXF1ZXN0LXJldmlldz9vd25lcj12YXJ1dGFzdSZyZXBvPXRjZy12YXVsdCZwcj02MSJ9 The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [tcg-vault](https://vercel.com/randall-stillwells-projects/tcg-vault) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/randall-stillwells-projects/tcg-vault/8HnEXAHt59dDTnMoSTNjbxyoQcXH) | [Preview](https://tcg-vault-git-chore-fix-lint-cac49b-randall-stillwells-projects.vercel.app), [Comment](https://vercel.live/open-feedback/tcg-vault-git-chore-fix-lint-cac49b-randall-stillwells-projects.vercel.app?via=pr-comment-feedback-link) | Jun 2, 2026 5:45am | <a href="https://vercel.com/vercel-agent/request-review?owner=varutasu&repo=tcg-vault&pr=61" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>

github-actions[bot] commented

2026-06-02 01:45:50 -04:00

(Migrated from github.com)

Pipeline Health

Build + CI gates

Gate	Status
Vercel build (Preview)	✅ pass
CI: Lint	✅ pass
CI: Schema map fresh	❌ skipped
Preview smoke	✅ pass
Visual diff	✅ pass

Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build).

Role reports

Role	Status
Reviewer report	⏳ pending
A11y audit	⏳ pending
Design system audit	⏳ pending

See individual comments above for details. This rollup updates automatically.

## Pipeline Health ### Build + CI gates | Gate | Status | | --- | --- | | Vercel build (Preview) | ✅ pass | | CI: Lint | ✅ pass | | CI: Schema map fresh | ❌ skipped | | Preview smoke | ✅ pass | | Visual diff | ✅ pass | _Build runs on Vercel; this CI runs lint and schema-map drift only (no duplicate build)._ ### Role reports | Role | Status | | --- | --- | | Reviewer report | ⏳ pending | | A11y audit | ⏳ pending | | Design system audit | ⏳ pending | See individual comments above for details. This rollup updates automatically.

github-actions[bot] commented

2026-06-02 01:46:54 -04:00

(Migrated from github.com)

Visual Diff

Screenshots and diffs uploaded as artifacts: view run

If intentional changes: update snapshots locally with npx playwright test --project=visual --update-snapshots and commit.

## Visual Diff Screenshots and diffs uploaded as artifacts: [view run](https://github.com/varutasu/tcg-vault/actions/runs/26801003304) If intentional changes: update snapshots locally with `npx playwright test --project=visual --update-snapshots` and commit.