rstillwell/deckhearth
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

feat(pricing): wire Lorcast (Lorcana) + TCGdex (Pokemon) + docs #161

Merged
rstillwell merged 2 commits from fix/mobile-overflow into main 2026-09-18 13:32:45 -04:00
Conversation 0 Commits 2 Files changed 1 +1 -1
rstillwell commented 2026-09-18 11:17:04 -04:00
Owner
Copy link
  • lib/card-import/lorcana-bulk.js: Lorcast per-card pricing via api.lorcast.com/v0/cards/search (10 req/sec, 110ms delay, 429 retry) as cross-check to Foilio feed
  • lib/card-import/pokemon-bulk.js: TCGdex pricing (already wired via lib/pricing/tcgdex-client.js)
  • test/lib/card-import-lorcana-bulk.test.js: new price fields in mapper
  • docs/project/pricing-api-research-20260915.md: final verified source matrix
  • docs/DOKPLOY_DEPLOY.md: pricing API env vars

Summary

Convoy + Brief

  • Convoy: .convoys/<slug>.md
  • Brief: .convoys/<slug>/brief-<N>-...md

Acceptance criteria

  • No scope expansion (only files listed in the brief's files: were edited)

Test plan

Pipeline gates

  • CI: lint, types, build, unit tests
  • Forbidden patterns / npm audit (if installed)
  • Visual diff (if UI change)
  • A11y audit (if UI change)
  • Design-system audit (if UI change)
  • Security audit (if code change)
  • Reviewer report
  • Smoke on staging (after merge to develop)

Security notes

Notes for reviewer

- lib/card-import/lorcana-bulk.js: Lorcast per-card pricing via api.lorcast.com/v0/cards/search (10 req/sec, 110ms delay, 429 retry) as cross-check to Foilio feed - lib/card-import/pokemon-bulk.js: TCGdex pricing (already wired via lib/pricing/tcgdex-client.js) - test/lib/card-import-lorcana-bulk.test.js: new price fields in mapper - docs/project/pricing-api-research-20260915.md: final verified source matrix - docs/DOKPLOY_DEPLOY.md: pricing API env vars <!-- PR title for convoy work: convoy: <short description> (pipeline: convoy=<slug>, brief=<N>) skip: <comma-separated flags or empty> Skip flags (Conductor sets these — do not edit by hand): ia, ux, arch, test, review, security, visual, a11y, design, smoke, qa, docs, flag Never skip: plan-approval, pr-merge, prod-promote When convoy-metrics-gate.yml is installed: convoy PRs must add rows to .convoys/.metrics.jsonl. Run scripts/log-convoy-event.sh after each role, or add skip-metrics label with reason in the PR body. --> ## Summary <!-- 2-3 bullets: what changed and why. User-facing language preferred. --> ## Convoy + Brief - Convoy: `.convoys/<slug>.md` - Brief: `.convoys/<slug>/brief-<N>-...md` ## Acceptance criteria <!-- Copy from the brief; check off as you complete. --> - [ ] - [ ] - [ ] No scope expansion (only files listed in the brief's `files:` were edited) ## Test plan <!-- What was tested, how, and what wasn't tested with rationale. --> ## Pipeline gates <!-- Filled in by CI / role-reviewer. Don't edit. --> - [ ] CI: lint, types, build, unit tests - [ ] Forbidden patterns / npm audit (if installed) - [ ] Visual diff (if UI change) - [ ] A11y audit (if UI change) - [ ] Design-system audit (if UI change) - [ ] Security audit (if code change) - [ ] Reviewer report - [ ] Smoke on staging (after merge to develop) ## Security notes <!-- Auth, permissions, or data-handling changes? Link security audit findings. --> ## Notes for reviewer <!-- Anything unusual, intentional trade-offs, or follow-ups. -->
rstillwell added 1 commit 2026-09-18 11:17:04 -04:00
feat(pricing): wire Lorcast (Lorcana) + TCGdex (Pokemon) + docs
Some checks failed
Preview smoke / Should run? (pull_request) Has been cancelled
Details
CI / Lint (pull_request) Has been cancelled
Details
CI / Schema map up to date (pull_request) Has been cancelled
Details
CI / Forbidden patterns (9 checks) (pull_request) Has been cancelled
Details
CI / Migrations apply (node-pg-migrate) (pull_request) Has been cancelled
Details
CI / Unit tests (vitest) (pull_request) Has been cancelled
Details
Convoy metrics gate / Require role-event telemetry on convoy PRs (pull_request) Has been cancelled
Details
PR Health rollup / Aggregate gate status (pull_request) Has been cancelled
Details
Preview smoke / Playwright smoke (pull_request) Has been cancelled
Details
6fcefa042f 
- lib/card-import/lorcana-bulk.js: Lorcast per-card pricing via api.lorcast.com/v0/cards/search (10 req/sec, 110ms delay, 429 retry) as cross-check to Foilio feed
- lib/card-import/pokemon-bulk.js: TCGdex pricing (already wired via lib/pricing/tcgdex-client.js)
- test/lib/card-import-lorcana-bulk.test.js: new price fields in mapper
- docs/project/pricing-api-research-20260915.md: final verified source matrix
- docs/DOKPLOY_DEPLOY.md: pricing API env vars
rstillwell closed this pull request 2026-09-18 12:38:28 -04:00
rstillwell reopened this pull request 2026-09-18 12:38:39 -04:00
rstillwell added 1 commit 2026-09-18 13:32:21 -04:00
Merge branch 'main' into fix/mobile-overflow
Some checks failed
CI / Lint (pull_request) Has been cancelled
Details
CI / Schema map up to date (pull_request) Has been cancelled
Details
CI / Forbidden patterns (9 checks) (pull_request) Has been cancelled
Details
CI / Migrations apply (node-pg-migrate) (pull_request) Has been cancelled
Details
CI / Unit tests (vitest) (pull_request) Has been cancelled
Details
Convoy metrics gate / Require role-event telemetry on convoy PRs (pull_request) Has been cancelled
Details
PR Health rollup / Aggregate gate status (pull_request) Has been cancelled
Details
Preview smoke / Should run? (pull_request) Has been cancelled
Details
Preview smoke / Playwright smoke (pull_request) Has been cancelled
Details
9d10c78104 
# Conflicts:
#	pages/api/auth/disconnect/route.js
rstillwell merged commit 02711f1bcd into main 2026-09-18 13:32:45 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-context-drift

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
agent-context-drift
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rstillwell/deckhearth#161
No description provided.
Delete branch "fix/mobile-overflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?