fix(auth): remove synthetic-admin bypass (Brief 2 of fix-auth-bypass)

Closes AGENTS.md gotcha #2: getUserFromRequest no longer returns a
hardcoded { userId: 1, email: 'admin@tcgvault.com', role: 'admin' }
when the Authorization header is missing or malformed.

lib/permission-middleware.js
  - getUserFromRequest now returns null for missing/malformed Bearer
    headers. No console.warn, no NODE_ENV gate — the fallback is gone,
    period.
  - Token-verify path and DB lookup unchanged.

pages/api/auth/verify.js
  - No-token branch now returns 401 instead of fetching the seed admin
    via `WHERE email = 'admin@tcgvault.com'`. Closes the admin-record-
    leak side of the same bypass.
  - JWT-verify branch unchanged.

Known follow-up (flagged but NOT addressed in this PR):
  pages/api/collections/[identifier]/cards.js POST/PUT/DELETE handlers
  dereference user.userId without a null guard. Previously masked by
  the synthetic admin (anonymous-write-as-admin on collections owned
  by user 1 was the security hole). Now degrades to NPE → 500 instead
  of a clean 401. Security is improved either way; cosmetic 500-vs-401
  fix lives in a separate one-line follow-up PR.

Convoy: fix-auth-bypass / Brief 2
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Randall Stillwell 2026-05-23 10:47:27 -05:00
parent 4a10dcedd3
commit 27e924c7cd
2 changed files with 2 additions and 16 deletions

View file

@ -10,9 +10,7 @@ export async function getUserFromRequest(req) {
const authHeader = req.headers.authorization;
if (!authHeader || !authHeader.startsWith('Bearer ')) {
// For development, return user ID 1 if no token (should be removed in production)
console.warn('⚠️ Development mode: Using fallback user authentication');
return { userId: 1, email: 'admin@tcgvault.com', role: 'admin' };
return null;
}
const token = authHeader.substring(7);

View file

@ -22,19 +22,7 @@ export default async function handler(req, res) {
const authHeader = req.headers.authorization;
if (!authHeader || !authHeader.startsWith('Bearer ')) {
// For development, return admin user if no token provided
// In production, this should return 401
const result = await sql`
SELECT id, email, role, created_at
FROM users
WHERE email = 'admin@tcgvault.com'
`;
if (result.rows.length > 0) {
return res.status(200).json(result.rows[0]);
} else {
return res.status(401).json({ error: 'No admin user found' });
}
return res.status(401).json({ error: 'Authentication required' });
}
const token = authHeader.substring(7);