From 1de0e0352221838e34bc195ae45f684d5d00f745 Mon Sep 17 00:00:00 2001
From: varutasu <104105839+varutasu@users.noreply.github.com>
Date: Mon, 25 May 2026 11:30:09 -0500
Subject: [PATCH] =?UTF-8?q?fix(migration):=20rename-admin-email=20crashes?=
 =?UTF-8?q?=20=E2=80=94=20neon()=20returns=20array,=20not=20{=20rows=20}?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hotfix to scripts/migrations/2026-05-24-rename-admin-email.js (shipped 2026-05-24 in pick-a-name PR #21). Script crashed on first invocation with 'TypeError: Cannot read properties of undefined (reading length)' at line 44. Root cause: architect designed against @vercel/postgres return shape { rows, rowCount } but the script uses @neondatabase/serverless's neon() tagged template which returns the rows array directly. AGENTS.md Gotcha #1 (two SQL clients in parallel) is exactly this kind of cross-contamination. Fix: drop the { rows: x } destructuring in all 3 sites + add a 4-line why comment block above the first site so the next migration author doesn't repeat. Verified hand-run against prod Neon DB: migrated 3 users (admin id=1, alice id=5, bob id=6) from @tcgvault.com to @deckhearth.com; idempotent re-run prints 'Nothing to migrate.' No data risk on the original crash — script exited at line 44 before reaching the UPDATE at line 54. PR #21 operator action item now complete in prod. Surfaces a P3 follow-up: add-neon-return-shape-rule (or fold into single-sql-client). All CI green: lint 128 baseline, vitest 21/21, Playwright smoke 3/3 in 1m2s, forbidden-cors-headers pass, forbidden-endpoints pass. PR #24, commit 98406fa.
---
 scripts/migrations/2026-05-24-rename-admin-email.js | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/scripts/migrations/2026-05-24-rename-admin-email.js b/scripts/migrations/2026-05-24-rename-admin-email.js
index ac880b0..7be1dfe 100644
--- a/scripts/migrations/2026-05-24-rename-admin-email.js
+++ b/scripts/migrations/2026-05-24-rename-admin-email.js
@@ -34,7 +34,11 @@ async function main() {
 
   const sql = neon(process.env.POSTGRES_URL);
 
-  const { rows: before } = await sql`
+  // NOTE: @neondatabase/serverless's tagged-template returns the rows array
+  // directly — NOT wrapped in { rows, rowCount } like @vercel/postgres does.
+  // See lib/database.js line 33 for the same finding. Do NOT destructure
+  // `{ rows: x }` from a `neon()` result; assign the result directly.
+  const before = await sql`
     SELECT id, email, role
     FROM users
     WHERE email LIKE '%@tcgvault.com'
@@ -58,7 +62,7 @@ async function main() {
     WHERE email LIKE '%@tcgvault.com'
   `;
 
-  const { rows: after } = await sql`
+  const after = await sql`
     SELECT id, email, role
     FROM users
     WHERE email LIKE '%@deckhearth.com'
@@ -70,7 +74,7 @@ async function main() {
     console.log(`  id=${r.id}  role=${r.role}  email=${r.email}`);
   }
 
-  const { rows: stragglers } = await sql`
+  const stragglers = await sql`
     SELECT COUNT(*)::int AS count FROM users WHERE email LIKE '%@tcgvault.com'
   `;
   if (stragglers[0].count !== 0) {